Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement generate RPC method #8834

Closed
Tracked by #8781
oxarbitrage opened this issue Sep 4, 2024 · 0 comments · Fixed by #8849
Closed
Tracked by #8781

Implement generate RPC method #8834

oxarbitrage opened this issue Sep 4, 2024 · 0 comments · Fixed by #8849
Assignees
@oxarbitrage
Labels
A-compatibility Area: Compatibility with other nodes or wallets, or standard rules A-rpc Area: Remote Procedure Call interfaces C-testing Category: These are tests P-Medium ⚡
Milestone
Zebra can replace...

Comments

@oxarbitrage
Copy link
Contributor

oxarbitrage commented Sep 4, 2024 •
edited
Loading

We want to make the zcashd rpc tests to work with zebra:

#8779
#8781

However, almost all the tests rely in a generate RPC method, for example: https://github.com/zcash/zcash/blob/master/qa/rpc-tests/getmininginfo.py#L34

The generate method is a Regtest mode only that mine a number of blocks immediately.

Docs: https://zcash.github.io/rpc/generate.html
Zcashd implementation: https://github.com/zcash/zcash/blob/master/src/rpc/mining.cpp#L169
@oxarbitrage oxarbitrage added C-testing Category: These are tests A-compatibility Area: Compatibility with other nodes or wallets, or standard rules P-Medium ⚡ A-rpc Area: Remote Procedure Call interfaces labels Sep 4, 2024
@oxarbitrage oxarbitrage mentioned this issue Sep 4, 2024
Closed
@oxarbitrage oxarbitrage self-assigned this Sep 4, 2024
@mpguerra mpguerra added this to the Zebra can replace `zcashd` milestone Sep 5, 2024
@oxarbitrage oxarbitrage mentioned this issue Sep 5, 2024
Merged
7 tasks
@mergify mergify bot closed this as completed in #8849 Sep 9, 2024
This was referenced Sep 17, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oxarbitrage oxarbitrage

Labels
A-compatibility Area: Compatibility with other nodes or wallets, or standard rules A-rpc Area: Remote Procedure Call interfaces C-testing Category: These are tests P-Medium ⚡
Projects
Zebra
Archived in project
Milestone
Zebra can replace `zcashd`
Development

Successfully merging a pull request may close this issue.

feat(rpc): Add a generate rpc method ZcashFoundation/zebra
2 participants
@mpguerra @oxarbitrage