-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tests): Move the RPC tests framework from zcashd #8866
Conversation
A lot of the files in this PR are moved from zcashd unmodified, almost everything inside
That covers 19 of the files added in this PR. Then, the proxy file, which is new, can be compared locally with the authproxy one as follows:
The only test moved can be compared with the one in zcashd as follows (no changes were done there, so the diff is empty):
|
2a1de9f
to
bcedbc2
Compare
bcedbc2
to
e376f3a
Compare
5b86f1d
to
aab646a
Compare
Output:
The above is what the CI needs to execute in the context of #8781 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
…n#8866) * move the rpc-tests framework from zcashd * ignore pycache * remove all tests from the list except getmininginfo * iimprove a bit the readme * change some env variable names * add cache, add reindex test * fix the paralell framework * fix env variables * change tests order * update docs with env variable name change * fix binary location * reduce base config * restore env var * ignore stderr in the output
Motivation
We want to integrate zcashd's RPC test framework with Zebra to ensure compatibility. To achieve this, we are migrating the framework and tests from zcashd to Zebra. Each test migration requires specific changes to Zebra, and this PR begins the process by moving the test framework and a few initial test.
This PR addresses parts of #8779 and #8781
Solution
This PR do the the groundwork for the migration, but it is not the complete solution.
Tests
Run the framework:
Individual tests:
Direct:
Follow-up Work
PR Author's Checklist
PR Reviewer's Checklist