Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement stop RPC method #8836

Closed
Tracked by #8781
oxarbitrage opened this issue Sep 4, 2024 · 0 comments · Fixed by #8839
Closed
Tracked by #8781

Implement stop RPC method #8836

oxarbitrage opened this issue Sep 4, 2024 · 0 comments · Fixed by #8839
Assignees
@oxarbitrage
Labels
A-compatibility Area: Compatibility with other nodes or wallets, or standard rules A-rpc Area: Remote Procedure Call interfaces C-testing Category: These are tests P-Medium ⚡
Milestone
Zebra can replace...

Comments

@oxarbitrage
Copy link
Contributor

We want to make the zcashd rpc tests work with Zebrad as the backend.
#8779

In those tests nodes are stopped by a stop RPC method: https://zcash.github.io/rpc/stop.html

We need to implement it for tests to work, we might want to make it regtest only similar to #8834 even if that does not seems to be how it is implemented in zcashd:

https://github.com/zcash/zcash/blob/master/src/rpc/server.cpp#L281
@oxarbitrage oxarbitrage added C-testing Category: These are tests A-rpc Area: Remote Procedure Call interfaces A-compatibility Area: Compatibility with other nodes or wallets, or standard rules P-Medium ⚡ labels Sep 4, 2024
@oxarbitrage oxarbitrage mentioned this issue Sep 4, 2024
Merged
7 tasks
@oxarbitrage oxarbitrage self-assigned this Sep 4, 2024
@mpguerra mpguerra modified the milestones: Zebra can replace `zcashd`, Regtest Network support Sep 5, 2024
@mergify mergify bot closed this as completed in #8839 Sep 9, 2024
This was referenced Sep 17, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oxarbitrage oxarbitrage

Labels
A-compatibility Area: Compatibility with other nodes or wallets, or standard rules A-rpc Area: Remote Procedure Call interfaces C-testing Category: These are tests P-Medium ⚡
Projects
Zebra
Archived in project
Milestone
Zebra can replace `zcashd`
Development

Successfully merging a pull request may close this issue.

feat(rpc): Add a stop rpc method ZcashFoundation/zebra
2 participants
@mpguerra @oxarbitrage