Fix/cc 446 code quality #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tw2113
added a commit
that referenced
this pull request
Nov 14, 2024
* Feature/cc 426 new update notification (#674) * early versions of new notification for urging to update the plugin. * new notification setup regarding pending updates * revise notification content to include links to the update page * fix typo * early return for non-admins * remove unneeded comparisons * early return for non CTCT sections * Feature/cc 438 failed disconnect submission hardening (#684) * move our missed api request method to public. * remove is_connected check and target our list array index more directly * begin checking if we have a list, but are not connected at the moment, and attempt to save the record * construct a contact array to match existing code * new methods to help with email notifications about API issues. Making this more direct and not dependent on logging in to see * colaborated wordsmithing with Constant Contact * fill in version number * Fix/cc 440 comment login signup errors (#683) * filter out woocommerce specific lists from the forms plugin * this is not serving any purpose * return early if we do not have any lists * while we should have a list item for each, do an empty check before trying to add to array * wp core get_option only has 2 parameters available to it. * Fix/cc 444 optin ux updates (#682) * remove old comments * build files * hide optin if we have no lists available but are connected * build files * fill in current changelog items, fill in misse CHANGELOG.md items * plugin version bumps for release branch * Fix/cc 446 code quality (#687) * miniscule phpcs * bump our phpcs minimum php version * update which standards we use, and exclude a new nested includes folder * phpcs file cleanup * strict in array checks, a couple of ignores for miniscule issues * yoda conditionals and array alignment * mark output as previously escaped * fix usage of esc_html__() * equals alignment * equals alignment * split assignment * phpcs cleanup for our auth link creation * phpcs cleanup for builder fields file * strict in array check, code spacing * remove some commeted out if statement logic * phpcs cleanup around translated text and array lines * I am fine with short ternary * ignore timestamp issue * various non-breaking phpcs changes * equal signs alignment and trailing commas * various phpcs changes for the lists file * phpcs cleanup for logging class * equals alignment * various phpcs touchups * disregard nonce need due to boolean check only * phpcs fixes * misc phpcs but also rename a function to be more specific to our plugin. * various phpcs touchups * make use of our textdomain escaping * make use of our textdomain escaping * much phpcs, ignoring some for the moment * we have had this mismatched for what we actually store and pass in for a while * We should update the option regardless of empty status, so that next disconect/reconnect attempt we make, we do not repeat previous processed entries * Fix/cc 442 block default selected form (#686) * attempt to provide a default form if we have at least 1 avaialble, and no pre-existing selected form * while we are here, touch up our messaging based on available form list. we were showing no dropdown with zero forms * compiled assets * handle an npm files version bump in this branch. fix an extra space * setting a default in this way was not saving attributes and thus not displaying a form. Instead we will provide a "select form" option to force choosing * build assets * remove now unused variable * mark our "Select" item as disabled if it is the only item in the array * amend our small messaging to reflect creating a form if we have only our blank "Select" item * build files * update pot file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles a bunch of PHPCS fixes and should-be-non-breaking code touch-ups across the plugin.