Release 2.7.0 (#688)

* Feature/cc 426 new update notification (#674)

* early versions of new notification for urging to update the plugin.

* new notification setup regarding pending updates

* revise notification content to include links to the update page

* fix typo

* early return for non-admins

* remove unneeded comparisons

* early return for non CTCT sections

* Feature/cc 438 failed disconnect submission hardening (#684)

* move our missed api request method to public.

* remove is_connected check and target our list array index more directly

* begin checking if we have a list, but are not connected at the moment, and attempt to save the record

* construct a contact array to match existing code

* new methods to help with email notifications about API issues. Making this more direct and not dependent on logging in to see

* colaborated wordsmithing with Constant Contact

* fill in version number

* Fix/cc 440 comment login signup errors (#683)

* filter out woocommerce specific lists from the forms plugin

* this is not serving any purpose

* return early if we do not have any lists

* while we should have a list item for each, do an empty check before trying to add to array

* wp core get_option only has 2 parameters available to it.

* Fix/cc 444 optin ux updates (#682)

* remove old comments

* build files

* hide optin if we have no lists available but are connected

* build files

* fill in current changelog items, fill in misse CHANGELOG.md items

* plugin version bumps for release branch

* Fix/cc 446 code quality (#687)

* miniscule phpcs

* bump our phpcs minimum php version

* update which standards we use, and exclude a new nested includes folder

* phpcs file cleanup

* strict in array checks, a couple of ignores for miniscule issues

* yoda conditionals and array alignment

* mark output as previously escaped

* fix usage of esc_html__()

* equals alignment

* equals alignment

* split assignment

* phpcs cleanup for our auth link creation

* phpcs cleanup for builder fields file

* strict in array check, code spacing

* remove some commeted out if statement logic

* phpcs cleanup around translated text and array lines

* I am fine with short ternary

* ignore timestamp issue

* various non-breaking phpcs changes

* equal signs alignment and trailing commas

* various phpcs changes for the lists file

* phpcs cleanup for logging class

* equals alignment

* various phpcs touchups

* disregard nonce need due to boolean check only

* phpcs fixes

* misc phpcs but also rename a function to be more specific to our plugin.

* various phpcs touchups

* make use of our textdomain escaping

* make use of our textdomain escaping

* much phpcs, ignoring some for the moment

* we have had this mismatched for what we actually store and pass in for a while

* We should update the option regardless of empty status, so that next disconect/reconnect attempt we make, we do not repeat previous processed entries

* Fix/cc 442 block default selected form (#686)

* attempt to provide a default form if we have at least 1 avaialble, and no pre-existing selected form

* while we are here, touch up our messaging based on available form list. we were showing no dropdown with zero forms

* compiled assets

* handle an npm files version bump in this branch. fix an extra space

* setting a default in this way was not saving attributes and thus not displaying a form. Instead we will provide a "select form" option to force choosing

* build assets

* remove now unused variable

* mark our "Select" item as disabled if it is the only item in the array

* amend our small messaging to reflect creating a form if we have only our blank "Select" item

* build files

* update pot file

CHANGELOG.md

@@ -1,3 +1,27 @@
+= 2.7.0 =
+
+* Fixed: Issues around opt-in options not showing until a list was chosen and the form saved.
+* Fixed: PHP warnings with login/register/comment signup integrations.
+* Added: Extra form submission catching if connection issues detected. Will notify administrators right away when
+  detected as well.
+* Updated: Dismissable admin notice recommending to update the Constant Contact Forms plugin when one is available.
+
+= 2.6.1 =
+
+* Fixed: Issues around opt-in option display that were introduced with version 2.6.0.
+* Fixed: Issues regarding lists display in admin emails after user signup.
+* Updated: Removed unused images and changed some.
+* Updated: Social sharing icons in plugin list page.
+
+= 2.6.0 =
+
+* Updated: Amended the list selection process for a given form. Should not break existing forms, and now you can make
+  use of drag-n-drop to order the list selection when offering multiple lists.
+* Updated: reworked the underpinning of the Constant Contact block to be more in line with modern WordPress coding
+  patterns, including block.json based. Should not break existing forms.
+* Updated: Show general List metabox regardless of connected status. Messaging will reflect connection state.
+* Added: New duration timing for a review request and displayed notification.
+
 = 2.5.0 =
 
 * Updated: Better handling of email notifications around spam submission attemptes.

assets/js/ctct-plugin-admin/optins.js

@@ -22,7 +22,7 @@ window.CTCT_OptIns = {};
 	app.cache = () => {
 		app.cache = {
 			optinNoConn: document.querySelectorAll( '#cmb2-metabox-ctct_1_optin_metabox #_ctct_opt_in_not_connected' ),
-			list: document.querySelectorAll('#cmb2-metabox-ctct_0_list_metabox .attached-posts-wrap .attached li'),
+			list: document.querySelectorAll('#cmb2-metabox-ctct_0_list_metabox .attached-posts-wrap .retrieved li'),
 			title: document.querySelectorAll( '#cmb2-metabox-ctct_1_optin_metabox .cmb2-id-email-optin-title' ),
 			optin: document.querySelectorAll( '#cmb2-metabox-ctct_1_optin_metabox .cmb2-id--ctct-opt-in' ),
 			instruct: document.querySelectorAll( '#cmb2-metabox-ctct_1_optin_metabox .cmb2-id--ctct-opt-in-instructions' )
@@ -37,7 +37,6 @@ window.CTCT_OptIns = {};
 	 */
 	app.bindEvents = () => {
 
-		// Only fire show/hide if we have the normal checkbox.
 		if ( app.cache.optinNoConn.length ) {
 
 			// Fire once to get our loaded state set up.
@@ -49,11 +48,7 @@ window.CTCT_OptIns = {};
 					app.toggleNoConnectionFields();
 				});
 			});
-		}
-
-		// Only fire show/hide if we have the normal checkbox.
-		if ( app.cache.list.length ) {
-
+		} else {
 			// Fire once to get our loaded state set up.
 			app.toggleConnectionFields();
 
@@ -94,7 +89,7 @@ window.CTCT_OptIns = {};
 	app.toggleConnectionFields = () => {
 
 		// If checked, show them, else hide it.
-		if ( 0 <= app.cache.list.length ) {
+		if ( 0 < app.cache.list.length ) {
 			Array.from(app.cache.title).forEach((item) => {
 				item.style.display = 'block';
 			});

build/block.json

@@ -2,7 +2,7 @@
   "$schema": "https://schemas.wp.org/trunk/block.json",
   "apiVersion": 3,
   "name": "constant-contact/single-contact-form",
-  "version": "2.6.0",
+  "version": "2.7.0",
   "title": "Constant Contact: Single Form",
   "category": "widgets",
   "icon": "index-card",

build/index.asset.php

@@ -1 +1 @@
-<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-data', 'wp-i18n'), 'version' => 'eede910bfcdc942469fc');
+<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-data', 'wp-i18n'), 'version' => '016ddd1f8af4d033948d');