Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/cc 446 code quality #687

Merged
merged 31 commits into from
Oct 24, 2024
Merged

Fix/cc 446 code quality #687

merged 31 commits into from
Oct 24, 2024

Commits on Sep 24, 2024

  1. miniscule phpcs

    @tw2113
    tw2113 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    f415f5f View commit details
    Browse the repository at this point in the history

  2. bump our phpcs minimum php version

    @tw2113
    tw2113 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    bea832d View commit details
    Browse the repository at this point in the history

  3. update which standards we use, and exclude a new nested includes folder

    @tw2113
    tw2113 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    c981c44 View commit details
    Browse the repository at this point in the history

  4. phpcs file cleanup

    @tw2113
    tw2113 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    a525b3b View commit details
    Browse the repository at this point in the history

  5. strict in array checks, a couple of ignores for miniscule issues

    @tw2113
    tw2113 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    e95ec66 View commit details
    Browse the repository at this point in the history

  6. yoda conditionals and array alignment

    @tw2113
    tw2113 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    3bc5081 View commit details
    Browse the repository at this point in the history

  7. mark output as previously escaped

    @tw2113
    tw2113 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    585941d View commit details
    Browse the repository at this point in the history

  8. fix usage of esc_html__()

    @tw2113
    tw2113 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    61b444c View commit details
    Browse the repository at this point in the history

  9. equals alignment

    @tw2113
    tw2113 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    48355d4 View commit details
    Browse the repository at this point in the history

  10. equals alignment

    @tw2113
    tw2113 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    9fe6dd7 View commit details
    Browse the repository at this point in the history

  11. split assignment

    @tw2113
    tw2113 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    6012e2e View commit details
    Browse the repository at this point in the history

  12. phpcs cleanup for our auth link creation

    @tw2113
    tw2113 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    6e820e1 View commit details
    Browse the repository at this point in the history

  13. phpcs cleanup for builder fields file

    @tw2113
    tw2113 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    c8d2b90 View commit details
    Browse the repository at this point in the history

  14. strict in array check, code spacing

    @tw2113
    tw2113 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    9feb413 View commit details
    Browse the repository at this point in the history

  15. remove some commeted out if statement logic

    @tw2113
    tw2113 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    25a5661 View commit details
    Browse the repository at this point in the history

  16. phpcs cleanup around translated text and array lines

    @tw2113
    tw2113 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    cc04174 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. I am fine with short ternary

    @tw2113
    tw2113 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    14c9fe6 View commit details
    Browse the repository at this point in the history

  2. ignore timestamp issue

    @tw2113
    tw2113 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    94b51f6 View commit details
    Browse the repository at this point in the history

  3. various non-breaking phpcs changes

    @tw2113
    tw2113 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    6baa946 View commit details
    Browse the repository at this point in the history

  4. equal signs alignment and trailing commas

    @tw2113
    tw2113 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    f6ab5a7 View commit details
    Browse the repository at this point in the history

  5. various phpcs changes for the lists file

    @tw2113
    tw2113 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    b10072d View commit details
    Browse the repository at this point in the history

  6. phpcs cleanup for logging class

    @tw2113
    tw2113 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    c91bcaa View commit details
    Browse the repository at this point in the history

  7. equals alignment

    @tw2113
    tw2113 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    dd767e0 View commit details
    Browse the repository at this point in the history

  8. various phpcs touchups

    @tw2113
    tw2113 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    1634c37 View commit details
    Browse the repository at this point in the history

  9. disregard nonce need due to boolean check only

    @tw2113
    tw2113 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    6fde0a7 View commit details
    Browse the repository at this point in the history

  10. phpcs fixes

    @tw2113
    tw2113 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    7fad4df View commit details
    Browse the repository at this point in the history

  11. misc phpcs but also rename a function to be more specific to our plugin.

    @tw2113
    tw2113 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    dc77a54 View commit details
    Browse the repository at this point in the history

  12. various phpcs touchups

    @tw2113
    tw2113 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    7eed9a4 View commit details
    Browse the repository at this point in the history

  13. make use of our textdomain escaping

    @tw2113
    tw2113 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    590d097 View commit details
    Browse the repository at this point in the history

  14. make use of our textdomain escaping

    @tw2113
    tw2113 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    4d92fab View commit details
    Browse the repository at this point in the history

  15. much phpcs, ignoring some for the moment

    @tw2113
    tw2113 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    524a07d View commit details
    Browse the repository at this point in the history