Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple ArXiv IDs #2337

Closed
wants to merge 5 commits into from

Conversation

carlinmack
Copy link
Collaborator

@carlinmack carlinmack commented Sep 16, 2023

Roadmap

This PR: Add support for multiple ArXiv IDs (in progress)

#2340 : Add support for other identifiers (doi for now) and change name

#2342: Add new tool which allows users to query for most recent papers which will be sent to this tool for finding presence in Wikidata and creating Quickstatements (CC @Daniel-Mietchen)

PR I'd like to do if I can: Upgrading citations.js (haven't been able to figure out) and potentially contributing some stuff upstream


Description

Please include a summary of the change, relevant motivation and context. If possible and applicable, include before and after screenshots and a URL where the changes can be seen.

Adds ability to submit multiple ArXiv IDs to the tool

image

Caveats

Please list anything which has been left out of this PR or which should be considered before this PR is accepted
Check any of the following which apply:

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
    • I have made corresponding changes to the documentation
  • This change requires new dependencies (please list)

If you make changes to the Python code

  • My code passes the tox check, I can receive warnings about tests, documentation or both

Testing

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce. Please also list any relevant details for your test configuration.

  • Tested with IDs which and found and not found (none, single and multiple)
  • Added a warning if there is an exception/no quickstatements are generated
image

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have not used code from external sources without attribution
  • I have considered accessibility in my implementation
  • There are no remaining debug statements (print, console.log, ...)

@carlinmack carlinmack changed the title ArXiv tool improvements Add support for multiple ArXiv IDs Sep 17, 2023
@carlinmack carlinmack marked this pull request as ready for review September 17, 2023 18:42
@egonw egonw requested a review from larsgw October 2, 2023 10:23
@larsgw larsgw removed their request for review October 2, 2023 11:24
@fnielsen fnielsen added the needs rebasing label for pull requests that are sent back for rebasing on the latest master (by author or other) label Oct 20, 2023
@fnielsen fnielsen mentioned this pull request Oct 31, 2023
10 tasks
@fnielsen
Copy link
Collaborator

Resolved conflicts and further edits. Carried to a new PR #2372 due to the complexity of resolving conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs rebasing label for pull requests that are sent back for rebasing on the latest master (by author or other)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants