-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to select a batch of QuickStatements to run #2345
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parent.insertAdjacentHTML('afterend', `<div class="alert alert-warning" role="alert">Select at least one row using the checkbox on the left</div>`); | ||
} else { | ||
const values = items.join('||'); | ||
window.location.href = "https://quickstatements.toolforge.org/#/v1=" + values |
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML Medium
DOM text
Error loading related location
Loading There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
values
is urlencoded on line 83 so I think it's okay
carlinmack
changed the title
Select qs
Add the ability to select a batch of QuickStatements to run
Oct 4, 2023
fnielsen
added
the
needs rebasing
label for pull requests that are sent back for rebasing on the latest master (by author or other)
label
Oct 31, 2023
10 tasks
Close in favour of #2509 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs rebasing
label for pull requests that are sent back for rebasing on the latest master (by author or other)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #2337 and #2340. Merge these first
Description
This PR adds the ability to act on many QuickStatements rather than running them individually
Caveats
If you make changes to the Python code
Testing
Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce. Please also list any relevant details for your test configuration.
Checklist