Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Check Crossref tool #2346

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

carlinmack
Copy link
Collaborator

@carlinmack carlinmack commented Oct 8, 2023

Builds on top of #2337 and #2340 Merge these first

Description

Please include a summary of the change, relevant motivation and context. If possible and applicable, include before and after screenshots and a URL where the changes can be seen.

This is the same functionality provided by the curation pages in #2342 but allows the user to edit the query directly rather than using the defaults set by the curation page tool

Users can either use the simple form inputs or edit the query string directly in the Advanced section. The "Submit" button sends the DOIs to the ID to QS tool, "Test query" button allows users to see the API results directly

image

Note: the date formatting in the date picker is set with the user's locale setting. For example in another of my browsers, the date shows as YYYY-MM-DD

Caveats

Please list anything which has been left out of this PR or which should be considered before this PR is accepted
Check any of the following which apply:

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
    • I have made corresponding changes to the documentation
  • This change requires new dependencies (please list)

If you make changes to the Python code

  • My code passes the tox check, I can receive warnings about tests, documentation or both

Testing

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce. Please also list any relevant details for your test configuration.

  • Checked that everything works as expected

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have not used code from external sources without attribution
  • I have considered accessibility in my implementation
  • There are no remaining debug statements (print, console.log, ...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant