Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename tyk charts #144

Merged
merged 18 commits into from
Oct 30, 2023
Merged

Rename tyk charts #144

merged 18 commits into from
Oct 30, 2023

Conversation

komalsukhani
Copy link
Collaborator

@komalsukhani komalsukhani commented Oct 27, 2023 •
edited
Loading

Description

  1. Rename chart tyk-single-dc to tyk-stack.
  2. Rename chart tyk-mdcb-data-plane to tyk-data-plane
  3. Rename chart tyk-enterprise-portal to tyk-dev-portal
  4. Deprecate tyk-single-dc, tyk-mdcb-data-plane and tyk-enterprise-portal chart.

Related Issue

TT-9769
TT-10195

Motivation and Context

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)
  • Documentation updates or improvements.

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • My change requires a change to the documentation.
    • I have manually updated the README(s)/documentation accordingly.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@komalsukhani komalsukhani marked this pull request as ready for review October 30, 2023 07:56
@komalsukhani komalsukhani requested a review from a team as a code owner October 30, 2023 07:56
@komalsukhani komalsukhani requested review from buraksekili and removed request for a team October 30, 2023 07:56
This was referenced Oct 30, 2023
Closed
Closed
buraksekili
buraksekili approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@buraksekili buraksekili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm overall. just left a couple of comments

.gitignore Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
tyk-data-plane/Chart.yaml Show resolved Hide resolved
@komalsukhani @buraksekili
Update README.md
e53d17c 
Co-authored-by: Burak Sekili <[email protected]>
@singhpr singhpr merged commit 342edb6 into main Oct 30, 2023
9 checks passed
@singhpr singhpr deleted the rename_tyk_charts branch October 30, 2023 09:07
@komalsukhani komalsukhani mentioned this pull request Oct 31, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buraksekili buraksekili buraksekili approved these changes

@andrei-tyk andrei-tyk andrei-tyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@komalsukhani @buraksekili @andrei-tyk @singhpr