Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TT-10195, renamed stuff in a backwards compatible manner #134

Closed
wants to merge 10 commits into from
Closed

TT-10195, renamed stuff in a backwards compatible manner #134

wants to merge 10 commits into from

Conversation

andrei-tyk
Copy link
Collaborator

@andrei-tyk andrei-tyk commented Oct 17, 2023 •
edited
Loading

Description

This PR aims to change the name of the enterprise portal to the newly agreed variant. Furthermore all variables were adapted in order to reflect this change.

Related Issue

Motivation and Context

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)
  • Documentation updates or improvements.

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • My change requires a change to the documentation.
    • I have manually updated the README(s)/documentation accordingly.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@andrei-tyk andrei-tyk requested a review from a team as a code owner October 17, 2023 09:26
@andrei-tyk andrei-tyk requested review from buraksekili and removed request for a team October 17, 2023 09:26
@andrei-tyk
Merge branch 'main' into TT-10195-rename-tyk-enterprise-portal-to-tyk…
adab2cd 
…-dev-portal

# Conflicts:
#	components/tyk-bootstrap/templates/bootstrap-post-install.yaml
#	components/tyk-bootstrap/templates/bootstrap-pre-delete.yaml
#	components/tyk-bootstrap/values.yaml
#	components/tyk-dev-portal/values.yaml
#	tyk-single-dc/values.yaml
@andrei-tyk
TT-10195, fixed merge conflicts
58d96c5
@andrei-tyk
TT-10195, fixes merge conflicts
efbe42e
buraksekili
buraksekili requested changes Oct 25, 2023
View reviewed changes
Copy link
Member

@buraksekili buraksekili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM. Thanks! Also, can you please update PR description?

components/tyk-bootstrap/values.yaml Show resolved Hide resolved
components/tyk-dev-portal/Chart.yaml Show resolved Hide resolved
components/tyk-dev-portal/values.yaml Outdated Show resolved Hide resolved
components/tyk-dev-portal/values.yaml Outdated Show resolved Hide resolved
@komalsukhani
Copy link
Collaborator

Closing in favour of #144

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buraksekili buraksekili buraksekili approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrei-tyk @komalsukhani @buraksekili @singhpr