Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: High-level overview of Pirate Metrics params & signals #223

Draft
wants to merge 2 commits into
base: feature/duration-signal
Choose a base branch
from

Conversation

Jeehut
Copy link
Contributor

@Jeehut Jeehut commented Dec 25, 2024

🚧 This is a Work-in-Progress PR. Do not merge! 🚧

My goal with this PR was to get an high-level overview of all the things need to be done for the pirate metrics topic.

@winsmith Please have a look at this code. This is how I imagine the whole thing to look like at the end. Of course, many details are missing, including documentation and all the various TODOs.

But rather than sending you one huge PR at the end, I want you to review & approve this overview first (without merging it!). Then, I can tackle one TODO at a time and send you small PRs that finalize various aspects, which will all target this branch. When all TODOs are done, you will already have reviewed & approved all code and can take a last "overall" look if you want, before we merge it.

Let me know if you have any concerns with this approach and if you have any concerns with the overall approach I've outlined in this PR. Looking forward to your feedback! And excited for the feature. 😍


These 14 subtasks need to be handled before we can publish a first version of "Pirate Metrics" to users:

These tasks can be tackled after the release:

@Jeehut Jeehut marked this pull request as draft December 25, 2024 15:33
@Jeehut Jeehut requested a review from winsmith December 25, 2024 15:35
@Jeehut Jeehut force-pushed the feature/pirate-metrics branch from 274ddd1 to a95682f Compare December 25, 2024 15:43
@Jeehut Jeehut changed the title WIP: Outline all new signals & parameters for Pirate Metrics (TODOs to finalize in other PRs) WIP: High-level overview of Pirate Metrics params & signals + duration signal Dec 25, 2024
@Jeehut Jeehut force-pushed the feature/pirate-metrics branch from a95682f to c98fd6e Compare December 25, 2024 15:55
@Jeehut Jeehut changed the base branch from main to feature/duration-signal December 25, 2024 15:55
@Jeehut Jeehut changed the title WIP: High-level overview of Pirate Metrics params & signals + duration signal WIP: High-level overview of Pirate Metrics params & signals Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant