Skip to content

Commit

Permalink
Make all helper functions publicly accessible & add documentation todo
Browse files Browse the repository at this point in the history
  • Loading branch information
Jeehut committed Dec 25, 2024
1 parent b91f46b commit c98fd6e
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 9 deletions.
File renamed without changes.
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import Foundation

public extension TelemetryDeck {
static func acquiredUser(
extension TelemetryDeck {
// TODO: add documentation comment with common/recommended usage examples

Check failure on line 4 in Sources/TelemetryDeck/PirateMetrics/TelemetryDeck+Acquisition.swift

View workflow job for this annotation

GitHub Actions / Lint Code

TODOs should be resolved (add documentation comment with...) (todo)
public static func acquiredUser(
channel: String,
parameters: [String: String] = [:],
customUserID: String? = nil
Expand All @@ -17,7 +18,8 @@ public extension TelemetryDeck {
)
}

static func leadStarted(
// TODO: add documentation comment with common/recommended usage examples
public static func leadStarted(
leadID: String,
parameters: [String: String] = [:],
customUserID: String? = nil
Expand All @@ -31,7 +33,8 @@ public extension TelemetryDeck {
)
}

static func leadConverted(
// TODO: add documentation comment with common/recommended usage examples
public static func leadConverted(
leadID: String,
parameters: [String: String] = [:],
customUserID: String? = nil
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import Foundation

extension TelemetryDeck {
static func onboardingCompleted(
// TODO: add documentation comment with common/recommended usage examples

Check failure on line 4 in Sources/TelemetryDeck/PirateMetrics/TelemetryDeck+Activation.swift

View workflow job for this annotation

GitHub Actions / Lint Code

TODOs should be resolved (add documentation comment with...) (todo)
public static func onboardingCompleted(
parameters: [String: String] = [:],
customUserID: String? = nil
) {
Expand All @@ -14,7 +15,8 @@ extension TelemetryDeck {
)
}

static func coreFeatureUsed(
// TODO: add documentation comment with common/recommended usage examples

Check failure on line 18 in Sources/TelemetryDeck/PirateMetrics/TelemetryDeck+Activation.swift

View workflow job for this annotation

GitHub Actions / Lint Code

TODOs should be resolved (add documentation comment with...) (todo)
public static func coreFeatureUsed(
featureName: String,
parameters: [String: String] = [:],
customUserID: String? = nil
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import Foundation

extension TelemetryDeck {
static func referralSent(
// TODO: add documentation comment with common/recommended usage examples

Check failure on line 4 in Sources/TelemetryDeck/PirateMetrics/TelemetryDeck+Referral.swift

View workflow job for this annotation

GitHub Actions / Lint Code

TODOs should be resolved (add documentation comment with...) (todo)
public static func referralSent(
receiversCount: Int = 1,
kind: String? = nil,
parameters: [String: String] = [:],
Expand All @@ -21,8 +22,9 @@ extension TelemetryDeck {
)
}

// TODO: add documentation comment with common/recommended usage examples

Check failure on line 25 in Sources/TelemetryDeck/PirateMetrics/TelemetryDeck+Referral.swift

View workflow job for this annotation

GitHub Actions / Lint Code

TODOs should be resolved (add documentation comment with...) (todo)
// TODO: explicitly mention how this can be used for NPS Score or for App Store like ratings

Check failure on line 26 in Sources/TelemetryDeck/PirateMetrics/TelemetryDeck+Referral.swift

View workflow job for this annotation

GitHub Actions / Lint Code

TODOs should be resolved (explicitly mention how this ca...) (todo)
static func userRatingSubmitted(
public static func userRatingSubmitted(
rating: Int,
comment: String? = nil,
parameters: [String: String] = [:],
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import Foundation

extension TelemetryDeck {
static func paywallShown(
// TODO: add documentation comment with common/recommended usage examples

Check failure on line 4 in Sources/TelemetryDeck/PirateMetrics/TelemetryDeck+Revenue.swift

View workflow job for this annotation

GitHub Actions / Lint Code

TODOs should be resolved (add documentation comment with...) (todo)
public static func paywallShown(
reason: String,
parameters: [String: String] = [:],
customUserID: String? = nil
Expand Down

0 comments on commit c98fd6e

Please sign in to comment.