Introduce automatic session tracking & enhance default parameters #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this commit was manually tested in a project and confirmed to work (persist, reset & count) as expected.
kkostov
reviewed
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the first 3 Pirate Metrics subtasks:
Note that I have expanded upon the requested
dayOfWeek,dayOfMonth, anddayOfYearfields and ended up with the following fields (the requirements comment was updated):TelemetryDeck.Calendar.dayOfWeek- Integer from 1 (Monday) to 7 (Sunday)TelemetryDeck.Calendar.dayOfMonth- Integer from 1 to 31, representing the day of the monthTelemetryDeck.Calendar.dayOfYear- Integer from 1 to 366 (accounting for leap years), representing the day of the yearTelemetryDeck.Calendar.weekOfYear- Integer from 1 to 53, representing the week of the yearTelemetryDeck.Calendar.monthOfYear- Integer from 1 to 12, representing the monthTelemetryDeck.Calendar.quarterOfYear- Integer from 1 to 4, representing the quarterTelemetryDeck.Calendar.hourOfDay- Integer from 1 to 24, representing the hourTelemetryDeck.Calendar.isWeekend- Bool,trueif Saturday or Sunday,falseotherwiseAll parameters use the Gregorian calendar and return -1 if the value cannot be calculated.
This PR is merge-ready as it targets the
feature/pirate-metricsbranch (which is 🚧 until all sub-tasks done).