[Enhancement] limit tablet write request size #50302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverbullet233
commented
Aug 27, 2024
trueeyu
reviewed
Aug 27, 2024
luohaha
previously approved these changes
Sep 13, 2024
luohaha
reviewed
Sep 13, 2024
luohaha
reviewed
Sep 13, 2024
Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: silverbullet233 <[email protected]>
silverbullet233
force-pushed
the
limit_tablet_sink_request_size
branch
from
9862259
to
5717597
Compare
Signed-off-by: silverbullet233 <[email protected]>
trueeyu
reviewed
Sep 18, 2024
| auto req = _rpc_request.mutable_requests(0); | ||
| for (size_t i = 0; i < filter_size; ++i) { | ||
| req->add_tablet_ids(tablet_ids[filtered_indexes[from + i]]); | ||
| } | ||
| } | ||
|
|
||
| if (_cur_chunk->num_rows() < _runtime_state->chunk_size()) { | ||
| if (_cur_chunk->num_rows() < _runtime_state->chunk_size() && | ||
| _cur_chunk_mem_usage < config::max_tablet_write_chunk_bytes) { |
There was a problem hiding this comment.
_cur_chunk->num_rows() <= 0 || (_cur_chunk->num_rows() < _runtime_state->chunk_size() && _cur_chunk_mem_usage < config::max_tablet_write_chunk_bytes) maybe better
There was a problem hiding this comment.
clone_empty_with_slot maybe reserve some memory, there maybe no one row in chunk, but memory exceed the limit.
Signed-off-by: silverbullet233 <[email protected]>
silverbullet233
force-pushed
the
limit_tablet_sink_request_size
branch
from
097add0
to
580fa07
Compare
luohaha
previously approved these changes
Sep 18, 2024
trueeyu
reviewed
Sep 19, 2024
trueeyu
previously approved these changes
Sep 19, 2024
Signed-off-by: silverbullet233 <[email protected]>
silverbullet233
dismissed stale reviews from trueeyu and luohaha
via
a53729f
trueeyu
approved these changes
Sep 19, 2024
chaoyli
reviewed
Sep 19, 2024
| // NOTE: If there are a large number of columns when loading, | ||
| // a too small max_tablet_write_chunk_bytes may cause more frequent RPCs, which may affect performance. | ||
| // In this case, we can try to increase the value to avoid the problem. | ||
| CONF_mInt64(max_tablet_write_chunk_bytes, "536870912"); |
There was a problem hiding this comment.
Why not keep the same size of protobuf limit?
There was a problem hiding this comment.
Why not keep the same size of protobuf limit?
Because this is not a hard limit, the chunk may exceed it. If it is set to 2GB, serialization will still fail once it exceeds the limit. 512MB is large enough for most scenarios.
luohaha
approved these changes
Sep 19, 2024
wyb
approved these changes
Sep 19, 2024
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]❌ fail : 0 / 24 (00.00%) file detail
|
dirtysalt
approved these changes
Sep 19, 2024
|
@Mergifyio backport branch-3.3 |
|
@Mergifyio backport branch-3.2 |
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 19, 2024
Signed-off-by: silverbullet233 <[email protected]> (cherry picked from commit ce25287)
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
Sep 19, 2024
Signed-off-by: silverbullet233 <[email protected]> (cherry picked from commit ce25287)
42 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Sep 19, 2024
Co-authored-by: eyes_on_me <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Sep 19, 2024
Co-authored-by: eyes_on_me <[email protected]>
|
Can we backport it to 3.2? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
When there are large chunks during the load process, the following error may be returned due to exceeding the size limit of protobuf.
NodeChannel currently only aggregates batches based on the function of the chunk, but does not take into account the size of the chunk.
What I'm doing:
In this PR, I have added chunk mem usage check to avoid generating large pb requests for load tasks
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: