Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] limit tablet write request size (backport #50302) #51172

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 19, 2024

Why I'm doing:

When there are large chunks during the load process, the following error may be returned due to exceeding the size limit of protobuf.
img_v3_02e4_eddde0ab-db20-4044-99a3-d6c6a82baf6g

NodeChannel currently only aggregates batches based on the function of the chunk, but does not take into account the size of the chunk.
img_v3_02e4_9f4f7683-ef85-49db-b315-5a3647cb863g

What I'm doing:

In this PR, I have added chunk mem usage check to avoid generating large pb requests for load tasks

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #50302 done by [Mergify](https://mergify.com). ## Why I'm doing: When there are large chunks during the load process, the following error may be returned due to exceeding the size limit of protobuf. ![img_v3_02e4_eddde0ab-db20-4044-99a3-d6c6a82baf6g](https://github.com/user-attachments/assets/7fd8ec87-7611-4462-a992-7c96f686f139)

NodeChannel currently only aggregates batches based on the function of the chunk, but does not take into account the size of the chunk.
img_v3_02e4_9f4f7683-ef85-49db-b315-5a3647cb863g

What I'm doing:

In this PR, I have added chunk mem usage check to avoid generating large pb requests for load tasks

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Signed-off-by: silverbullet233 <[email protected]>
(cherry picked from commit ce25287)
@wanpengfei-git wanpengfei-git merged commit 38e2009 into branch-3.3 Sep 19, 2024
32 of 33 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.3/pr-50302 branch September 19, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants