Skip to content

Commit

Permalink
fix comments
Browse files Browse the repository at this point in the history
Signed-off-by: silverbullet233 <[email protected]>
  • Loading branch information
silverbullet233 committed Sep 18, 2024
1 parent 3ca485f commit 580fa07
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions be/src/common/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -703,8 +703,8 @@ CONF_Int32(metric_late_materialization_ratio, "1000");

// Max batched bytes for each transmit request. (256KB)
CONF_Int64(max_transmit_batched_bytes, "262144");
// max chunk size for each tablet write request. (128MB)
CONF_mInt64(max_tablet_write_chunk_bytes, "134217728");
// max chunk size for each tablet write request. (512MB)
CONF_mInt64(max_tablet_write_chunk_bytes, "536870912");

CONF_Int16(bitmap_max_filter_items, "30");

Expand Down
8 changes: 4 additions & 4 deletions be/src/exec/tablet_sink_index_channel.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -467,8 +467,8 @@ Status NodeChannel::add_chunk(Chunk* input, const std::vector<int64_t>& tablet_i
}
}

if (_cur_chunk->num_rows() < _runtime_state->chunk_size() &&
_cur_chunk_mem_usage < config::max_tablet_write_chunk_bytes) {
if (_cur_chunk->num_rows() <= 0 || (_cur_chunk->num_rows() < _runtime_state->chunk_size() &&
_cur_chunk_mem_usage < config::max_tablet_write_chunk_bytes)) {
// 2. chunk not full
if (_request_queue.empty()) {
return Status::OK();
Expand Down Expand Up @@ -520,8 +520,8 @@ Status NodeChannel::add_chunks(Chunk* input, const std::vector<std::vector<int64
}
}

if (_cur_chunk->num_rows() < _runtime_state->chunk_size() &&
_cur_chunk_mem_usage < config::max_tablet_write_chunk_bytes) {
if (_cur_chunk->num_rows() <= 0 || (_cur_chunk->num_rows() < _runtime_state->chunk_size() &&
_cur_chunk_mem_usage < config::max_tablet_write_chunk_bytes)) {
// 2. chunk not full
if (_request_queue.empty()) {
return Status::OK();
Expand Down

0 comments on commit 580fa07

Please sign in to comment.