Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inline destructor in solvers folder. #22018

Conversation

hongkai-dai
Copy link
Contributor

@hongkai-dai hongkai-dai commented Oct 10, 2024

Towards #22015


This change is Reviewable

Copy link
Contributor Author

@hongkai-dai hongkai-dai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@jwnimmer-tri for feature review please, thanks!

Reviewable status: LGTM missing from assignee jwnimmer-tri(platform), needs at least two assigned reviewers, missing label for release notes (waiting on @hongkai-dai)

@jwnimmer-tri jwnimmer-tri added release notes: fix This pull request contains fixes (no new features) status: single reviewer ok https://drake.mit.edu/reviewable.html labels Oct 10, 2024
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :lgtm: both +(status: single reviewer ok) +(release notes: fix).

Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: 2 unresolved discussions


solvers/ipopt_solver_internal.h line 65 at r1 (raw file):

                  MathematicalProgramResult* result);

  virtual ~IpoptSolver_NLP()

nit Missing ; (CI complaints).


solvers/minimum_value_constraint.cc line 234 at r1 (raw file):

}

MinimumValueLowerBoundConstraint::~MinimumValueLowerBoundConstraint() = default;

nit Move this up in the file by 1 function, so it sits after the constructor definition but prior to the set function definition.

@hongkai-dai hongkai-dai force-pushed the remove_destructor_in_solvers_headers branch from c83e0f1 to 37bea71 Compare October 10, 2024 16:22
@hongkai-dai hongkai-dai force-pushed the remove_destructor_in_solvers_headers branch from 37bea71 to 73a47ff Compare October 10, 2024 16:23
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee jwnimmer-tri(platform)

@jwnimmer-tri jwnimmer-tri merged commit ca878eb into RobotLocomotion:master Oct 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: fix This pull request contains fixes (no new features) status: single reviewer ok https://drake.mit.edu/reviewable.html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants