Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for col_select. #9

Merged
merged 5 commits into from
Jul 29, 2024
Merged

Fix for col_select. #9

merged 5 commits into from
Jul 29, 2024

Conversation

Nic-Chr
Copy link
Contributor

@Nic-Chr Nic-Chr commented Jul 23, 2024

No description provided.

@Moohan
Copy link
Member

Moohan commented Jul 23, 2024

Thanks Nic, this does make it work in this case get_spd(col_select = dplyr::matches("pc[78]")) but it still doesn't work in this case get_spd(col_select = c("pc7", dplyr::starts_with("hb"))) although it's a much more interesting error than previously :D

I made a commit to add some tests with these two examples

@Nic-Chr
Copy link
Contributor Author

Nic-Chr commented Jul 25, 2024

It's because the curly braces aren't used in get_spd(). For tidy expressions to work you need to create quosures and defuse them throughout each function call.

I've now fixed this in the latest commit but do let me know if it doesn't work as intended.

Copy link
Member

@Moohan Moohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Nic, all works great now.

@Moohan Moohan enabled auto-merge (squash) July 29, 2024 12:14
@Moohan Moohan disabled auto-merge July 29, 2024 15:23
@Moohan Moohan merged commit 4d85123 into main Jul 29, 2024
3 of 5 checks passed
@Moohan Moohan deleted the col_select_fix branch July 29, 2024 15:23
@Moohan Moohan linked an issue Oct 7, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

col_select doesn't work with selection helpers
2 participants