Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

col_select doesn't work with selection helpers #8

Closed
Moohan opened this issue Jul 22, 2024 · 2 comments · Fixed by #9
Closed

col_select doesn't work with selection helpers #8

Moohan opened this issue Jul 22, 2024 · 2 comments · Fixed by #9

Comments

@Moohan
Copy link
Member

Moohan commented Jul 22, 2024

col_select should work with selection helpers, e.g. it should be possible to do get_spd(col_select = c("pc7", dplyr::starts_with("hscp")) but this doesn't work. I guess it's something to do with how it's being passed between functions and tied up with 'non-standard evaluation' etc. which just hurts my head!

@Nic-Chr
Copy link
Contributor

Nic-Chr commented Jul 23, 2024

Try replacing !!col_select with {{ col_select }}. I think the former can theoretically also only work with 1 column.

@Nic-Chr
Copy link
Contributor

Nic-Chr commented Jul 23, 2024

I've hopefully fixed the issue in the new PR #9

@Moohan Moohan linked a pull request Oct 7, 2024 that will close this issue
@Moohan Moohan closed this as completed Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants