Fix newline issue

[pac48]

Newlines were breaking the code generation for Python #170. This PR fixes the issue and reformats the C++ to print better with ros2 param describe... The following out shows the new format.

Parameter name: hover_override
  Type: integer
  Description: Override hover action:
    0: Hover
    1: Push
    2: Pull
    -1: Do not override
  Constraints:

The old format was like this

Parameter name: hover_override
  Type: integer
  Description: Override hover action: 0: Hover 1: Push 2: Pull -1: Do not override
  Constraints:

[christophfroehlich]

Looks fine for me.

Fyi, I have to change the parameter description of joint_trajectory_controller because I used \pi inside the description for rendering with sphinx -> without replacement of all \ it throws warnings now. But it still works, and output of ros2 param describe looks way better.

[pac48]

Looks fine for me.

Fyi, I have to change the parameter description of joint_trajectory_controller because I used \pi inside the description for rendering with sphinx -> without replacement of all \ it throws warnings now. But it still works, and output of ros2 param describe looks way better.

@christophfroehlich Do you mind giving this PR an approval review once you have made the changes you need to make to the joint_trajectory_controller?

[christophfroehlich]

Or this should be fine too? This would fix your indent and also the markdown syntax I added to JTC.

Suggested change

	filtered_description = description.replace('\n', '\\n ')
	# remove possible markdown/rst syntax, but add proper indent for cpp-header files.
	filtered_description = description.replace('\\', '\\\\').replace('`', '').replace('\\n', '\\n ')

[pac48]

I added this change but made one small change. It should replace \n' with \n' for the new liens to render correctly.

[christophfroehlich]

I tested it with joint_trajectory_controller, it works perfectly now.

[saikishor]

Hello!

Thank you for fixing it. When can we expect to have this fix released upstream?