Remove over-riding of ctrl block ack ports where feasible #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennchid
force-pushed
the
reg_read_fix
branch
from
c77c21c to
15c0908
Compare
* write_ack now set in ctrl block and not wrapper * read_ack over-riding removed for hardware blocks * read_ack added to modules which did not have one previously
glennchid
force-pushed
the
reg_read_fix
branch
from
15c0908 to
5b17c02
Compare
|
Moved DRV acks for PCAP inside the pcap_core_ctl (non-autogenerated) for consistency, so pcap is now less of a special case. |
Araneidae
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only blocks which treat the
acksdifferenently aresystemdue to the slow FPGA registers, andpcapdue to the DRV block.NB: I checked this built for all zpkgs and tested one zpkg on hardware and it worked fine, but just noticed this is failing the python tests on PR. I think I can fix this before merging.