-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
purePursuit: migrate parameters to library #23438
Conversation
48af8bd
to
fc7e0ec
Compare
fc7e0ec
to
180079d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a clean iteration!
src/modules/rover_ackermann/RoverAckermannGuidance/RoverAckermannGuidance.hpp
Show resolved
Hide resolved
src/modules/rover_ackermann/RoverAckermannGuidance/RoverAckermannGuidance.cpp
Outdated
Show resolved
Hide resolved
src/modules/rover_ackermann/RoverAckermannGuidance/RoverAckermannGuidance.hpp
Outdated
Show resolved
Hide resolved
acd8e20
to
3e541c2
Compare
@chfriedrich98 Good change. FYI If you ever touch a parameter name, worth doing a search in the docs. If you add a parameter think "what difference might this make to end users" because perhaps new docs are needed. The reason I note this is that the parameters auto updated and broke some links you fixed up previously in PX4/PX4-user_guide#3265. I do plan to add some automation to remind developers, and perhaps move docs into this repo so you might find them with search and replace. Ultimately though we need to think about what end-user impacts changes might have. P.S. Should also do search replace in the source - because these also mentioned in https://github.com/PX4/PX4-Autopilot/blob/main/src/lib/pure_pursuit/PurePursuit.hpp#L98-L100 |
@hamishwillee Thanks for the reminder!
The fix for that is part of this PR: https://github.com/PX4/PX4-Autopilot/pull/23470/files. |
Solved Problem
The pure pursuit library introduced in #23387 requires some parameters that are currently defined in the ackermann module.
Migrating them to the library itself avoids having to redifine the same parameters for every module that uses the pure pursuit library in the future.
This effects the following parameters: