AirspeedValidator: Remove extra delay from airspeed innovation check #23244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ggering innovation checks - this check already uses an integrator and so adding more delay just makes log analysis more difficult and does not really add any value Signed-off-by: RomanBapst <[email protected]>
sfuhrer
reviewed
Jun 10, 2024
Signed-off-by: RomanBapst <[email protected]>
…tive Signed-off-by: Silvan Fuhrer <[email protected]>
sfuhrer
previously approved these changes
Jun 11, 2024
Signed-off-by: RomanBapst <[email protected]>
sfuhrer
approved these changes
Jun 11, 2024
chiara-septentrio
pushed a commit
to flyingthingsintothings/PX4-Autopilot
that referenced
this pull request
Jul 3, 2024
…X4#23244) * AirspeedValidator: remove additional one second of hysteresis for triggering innovation checks - this check already uses an integrator and so adding more delay just makes log analysis more difficult and does not really add any value Signed-off-by: RomanBapst <[email protected]> * removed unnecessary conditions Signed-off-by: RomanBapst <[email protected]> * AirspeedValidator: only disable innov checks if ASPD_FS_INTEG is negative Signed-off-by: Silvan Fuhrer <[email protected]> * get rid of unnecessary check on innovation threshold parameter Signed-off-by: RomanBapst <[email protected]> --------- Signed-off-by: RomanBapst <[email protected]> Signed-off-by: Silvan Fuhrer <[email protected]> Co-authored-by: Silvan Fuhrer <[email protected]>
chiara-septentrio
pushed a commit
to flyingthingsintothings/PX4-Autopilot
that referenced
this pull request
Jul 4, 2024
…X4#23244) * AirspeedValidator: remove additional one second of hysteresis for triggering innovation checks - this check already uses an integrator and so adding more delay just makes log analysis more difficult and does not really add any value Signed-off-by: RomanBapst <[email protected]> * removed unnecessary conditions Signed-off-by: RomanBapst <[email protected]> * AirspeedValidator: only disable innov checks if ASPD_FS_INTEG is negative Signed-off-by: Silvan Fuhrer <[email protected]> * get rid of unnecessary check on innovation threshold parameter Signed-off-by: RomanBapst <[email protected]> --------- Signed-off-by: RomanBapst <[email protected]> Signed-off-by: Silvan Fuhrer <[email protected]> Co-authored-by: Silvan Fuhrer <[email protected]>
vertiq-jordan
pushed a commit
to iq-motion-control/PX4-Autopilot
that referenced
this pull request
Aug 21, 2024
…X4#23244) * AirspeedValidator: remove additional one second of hysteresis for triggering innovation checks - this check already uses an integrator and so adding more delay just makes log analysis more difficult and does not really add any value Signed-off-by: RomanBapst <[email protected]> * removed unnecessary conditions Signed-off-by: RomanBapst <[email protected]> * AirspeedValidator: only disable innov checks if ASPD_FS_INTEG is negative Signed-off-by: Silvan Fuhrer <[email protected]> * get rid of unnecessary check on innovation threshold parameter Signed-off-by: RomanBapst <[email protected]> --------- Signed-off-by: RomanBapst <[email protected]> Signed-off-by: Silvan Fuhrer <[email protected]> Co-authored-by: Silvan Fuhrer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
The additional hardcoded delay of 1 second on the airspeed innovation check does not add any value as the check itself uses an integrator to trigger and just makes analyzing a failure in a log file more difficult.
There is a separate parameter to control the delay between a detecting a failure and declaring airspeed invalid.
Solution
Remove the additional delay.
Changelog Entry
For release notes: