Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mixer function RC: output disarmed value with no valid RC input #23213

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MaEtUgR
Copy link
Member

@MaEtUgR MaEtUgR commented May 31, 2024

Solved Problem

I received the report from @fury1895 that when:

  • mapping a servo to an RC input e.g. aux1
  • enabling COM_PREARM_MODE
  • Not connecting any RC
    the servo goes to the center position instead of the configured disarmed position.

Solution

I agree that this is unexpected and suggest that actuators mapped to and RC input directly get commanded their disarmed output whenever the RC input is not available (anymore).

Changelog Entry

Bugfix
Documentation: mention this behavior explicitly under https://docs.px4.io/main/en/config/actuators.html#output-functions

Alternatives

We could keep the last valid RC input instead but it's not only more complicated I also currently don't exactly see what use case would require this behavior.

Test coverage

This was not tested. Please @fury1895 test and give feedback.

@MaEtUgR MaEtUgR added the bug label May 31, 2024
@MaEtUgR MaEtUgR self-assigned this May 31, 2024
@MaEtUgR MaEtUgR changed the title mixer function RC: use disarmed value without valid RC input mixer function RC: use disarmed value with no valid RC input May 31, 2024
@MaEtUgR MaEtUgR changed the title mixer function RC: use disarmed value with no valid RC input mixer function RC: output disarmed value with no valid RC input May 31, 2024
@MaEtUgR MaEtUgR force-pushed the maetugr/actuator-do-not-use-invalid-manual-control branch from 8df22c3 to b1270f4 Compare May 31, 2024 14:41
@github-actions github-actions bot added the stale label Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant