Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mission check land when no approach #22750

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

KonradRudin
Copy link
Contributor

Solved Problem

When a VTOL is flying in air, we want to make sure that a landing is defined either by VTOL land approaches on home/rally points or the mission. Thus when uploading a new mission in air, the mission should get rejected, when it does not define a landing and there are no landing approaches defined for the safe points.

Fixes #{Github issue ID}

Solution

Add a new mission check option in MIS_TKO_LAND_REQ. This option checks, if a landing is defined, when in air and no safe point approaches are defined. While on the ground, it will use the same logic as MIS_TKO_LAND_REQ=4

Changelog Entry

For release notes:

Feature: New Mission takeoff/landing required option to check for a valid landing (either mission landing or land approaches) when in air.

Test coverage

@KonradRudin KonradRudin force-pushed the add_mission_check_land_when_no_approach branch from 48e433e to 6090040 Compare February 15, 2024 07:36
sfuhrer
sfuhrer previously approved these changes Feb 15, 2024
Copy link
Contributor

@sfuhrer sfuhrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, and the extra RTL debugging should help as well!

msg/RtlStatus.msg Outdated Show resolved Hide resolved
msg/RtlStatus.msg Outdated Show resolved Hide resolved
ADd a new misison feasiblity checker option to check if a proper landing approach is defined when in air. There must be at least a mission landing or a VTOL approach defined in order for the mission to be accepted. Else, use the same logic as in MIS_TKO_LAND_REQ=4
@KonradRudin KonradRudin force-pushed the add_mission_check_land_when_no_approach branch from 9713c78 to 3565df7 Compare February 15, 2024 15:27
@sfuhrer sfuhrer merged commit 424c3cd into main Feb 16, 2024
90 of 92 checks passed
@sfuhrer sfuhrer deleted the add_mission_check_land_when_no_approach branch February 16, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants