-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NPFG: Add fallback for corner cases #22411
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KonradRudin thanks for the sanitizer! great to handle these cases now. However -- see the comment about blending to zero instead of last roll setpoint. I approved because I'll be out of office and unable to approve later... but I actually think blending to zero is the better solution in the degraded input cases. If there are strong reasons I am wrong about this .. please feel free to discuss also with @RomanBapst and @sfuhrer and you three can override my opinion ;)
c724ade
to
55d4834
Compare
Rebased on main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed I would add some user notification when the factor drops below 1 (but has been above 1 before).
And I would consider reducing COM_VEL_FS_EVH by default a bit, as it would be bad if NPFG doesn't control roll any more because the estimator reports a very high velocity uncertainty but there is no failsafe action triggered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now! Let's clean up the commits and bring it in then.
20c9eda
to
b791979
Compare
Squashed the commits and rebased on main. |
@KonradRudin can you check if the CI failures are real? |
…e test buffer There were already checks at runtime, but this ensures the format is not too long at built-time.
Solved Problem
The NPFG controller can't produce reliable roll setpoints when the wind estimation is not yet valid and the ground speed is close to zero or the vehcile is pushed back by the wind. This is a more general fix for #22003
Fixes #{Github issue ID}
Solution
Changelog Entry
For release notes: