Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compound file updated to V11 and evaluation plan #3

Open
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

mgsc1020
Copy link

please review @PavelBal

@Yuri05
Copy link
Member

Yuri05 commented Dec 23, 2024

Please rename Metformin-Model V11.json to Metformin-Model.json

@Yuri05
Copy link
Member

Yuri05 commented Dec 23, 2024

Missing observed data mappings in some simulations under metformin model verification po
grafik

@Yuri05
Copy link
Member

Yuri05 commented Dec 23, 2024

some cross references in report seem to be invalid:
grafik

@Yuri05
Copy link
Member

Yuri05 commented Dec 23, 2024

Author name seems to be used inconsistently: Morissey vs. Morrisey vs. Morrissey

@mgsc1020
Copy link
Author

mgsc1020 commented Jan 3, 2025

@Yuri05 thank you for your comments. I addressed the author names and data mappings.
For the comment on the cross-references to report sections #221, #222, and #224 comment, can you give me a hint on how to solve this? I don't think I ran into this error when I ran the report, and I'm unsure how to track it from my side.

@Yuri05
Copy link
Member

Yuri05 commented Jan 3, 2025

For the comment on the cross-references to report sections #221, #222, and #224 comment, can you give me a hint on how to solve this? I don't think I ran into this error when I ran the report, and I'm unsure how to track it from my side.

For those chapters no header numbers were created (e.g. compare https://github.com/Yuri05/Metformin-Model/blob/review/Evaluation/report/report.md#in-vitro-and-physicochemical-data).

So you have 3 alternative options for fixing:

  1. Adjust the references (e.g. use #in-vitro-and-physicochemical-data instead of #221-in-vitro-and-physicochemical-data)
  2. Add subchapter numbers to your static content (would not do this).
  3. [Best option] Create your own anchors as described under https://www.open-systems-pharmacology.org/OSPSuite.ReportingEngine/articles/qualification-workflow.html#referencing
  • For subchapters which are referenced elsewhere, add <a id="chapter-reference-id"></a> directly above or directly after the chapter header in the markdown file. Use only lower case letters, "-" and digits, e.g.

### In vitro and physicochemical data<a id="in-vitro-data"></a>

  • Then you can always reference the chapter by its anchor as [s. tralala](#in-vitro-data)
    This is the safest way as it does not rely on the chapter number, chapter title or the way how the GitHub referencing replaces the special characters in automatically created anchors.

Evaluation/Input/Content/Section1_Introduction.md Outdated Show resolved Hide resolved
Evaluation/Input/Content/Section1_Introduction.md Outdated Show resolved Hide resolved
Evaluation/Input/Content/Section1_Introduction.md Outdated Show resolved Hide resolved
Evaluation/Input/Content/Section1_Introduction.md Outdated Show resolved Hide resolved
Evaluation/Input/Content/Section2.1_Modeling_Strategy.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants