Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0] [FIX] helpdesk_mgmt: company_id should come from team #553

Merged
merged 1 commit into from
Sep 4, 2024
Merged

[15.0] [FIX] helpdesk_mgmt: company_id should come from team #553

merged 1 commit into from
Sep 4, 2024

Conversation

eLBati
Copy link
Member

@eLBati eLBati commented Mar 25, 2024

Otherwise, creating tickets from fetchmail would always set odoobot's company in new tickets, potentially in contrast to team's company

@ByteMeAsap
Copy link
Contributor

@eLBati , the company would be undefined in case it is created manually without adding any team

@eLBati
[FIX] helpdesk_mgmt: company_id should come from team
3e8305c 
Otherwise, creating tickets from fetchmail would always set odoobot's company in new tickets, potentially in contrast to team's company
@eLBati
Copy link
Member Author

eLBati commented Apr 12, 2024

@ByteMeAsap why do you think this would be a problem?
Record rule helpdesk_ticket_comp_rule expects tickets without company.

Anyway, I also added _default_team_id , please review

Thanks

marcelsavegnago
marcelsavegnago approved these changes May 23, 2024
View reviewed changes
Copy link
Sponsor Member

@marcelsavegnago marcelsavegnago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

flotho
flotho approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review, LGTM

@LorenzoC0 LorenzoC0 mentioned this pull request Sep 4, 2024
Closed
@rvalyi
Copy link
Member

rvalyi commented Sep 4, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-553-by-rvalyi-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 880ddfa into OCA:15.0 Sep 4, 2024
4 of 5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1bff112. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza added this to the 15.0 milestone Sep 5, 2024
@pedrobaeza pedrobaeza mentioned this pull request Sep 5, 2024
Merged
@pedrobaeza
Copy link
Member

Reverted in #619

See #618 (review)

@rvalyi you merged just after I request the review of my colleague, which has been working on this question a lot. It's true that the PR has been here a lot of time, but we didn't see it, sorry. But this is breaking some flows that were designed to work that way. @victoralmau maybe you can add some tests for that flows.

victoralmau added a commit to Tecnativa/helpdesk that referenced this pull request Sep 5, 2024
@victoralmau
[IMP] helpdesk_mgmt: Add _default_team_id to team_id field from tickets
50ef62c 
Related to OCA#553
victoralmau added a commit to Tecnativa/helpdesk that referenced this pull request Sep 5, 2024
@victoralmau
[IMP] helpdesk_mgmt: Add _default_team_id to team_id field from tickets
1f55d82 
Related to OCA#553
@victoralmau victoralmau mentioned this pull request Sep 5, 2024
Merged
@eLBati
Copy link
Member Author

eLBati commented Sep 5, 2024

Replacing with #622

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvalyi rvalyi rvalyi approved these changes

@flotho flotho flotho approved these changes

@marcelsavegnago marcelsavegnago marcelsavegnago approved these changes

@DarioLodeiros DarioLodeiros Awaiting requested review from DarioLodeiros

@victoralmau victoralmau Awaiting requested review from victoralmau

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
7 participants
@eLBati @ByteMeAsap @rvalyi @OCA-git-bot @pedrobaeza @flotho @marcelsavegnago