Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discord: update all discord packages #347886

Merged
merged 2 commits into from
Oct 12, 2024

Conversation

Scrumplex
Copy link
Member

@Scrumplex Scrumplex commented Oct 11, 2024

Closes #347858

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Discord changed their download URLs and the new code is now more lenient
regarding the actual download URL, as all we care about is the version
in the URL path.

Example:
https://ptb.dl2.discordapp.net/apps/linux/0.0.110/discord-ptb-0.0.110.tar.gz
                                          ^-----^
                                     This is what we need

Signed-off-by: Sefa Eyeoglu <[email protected]>
@Scrumplex
Copy link
Member Author

Result of nixpkgs-review pr 347886 run on x86_64-linux 1

4 packages built:
  • discord
  • discord-canary
  • discord-development
  • discord-ptb

@Scrumplex
Copy link
Member Author

Result of nixpkgs-review pr 347886 run on aarch64-darwin 1

4 packages built:
  • discord
  • discord-canary
  • discord-development
  • discord-ptb

@jopejoe1 jopejoe1 added the backport release-24.05 Backport PR automatically label Oct 11, 2024
@Artturin Artturin merged commit fe17be0 into NixOS:master Oct 12, 2024
61 of 62 checks passed
Copy link
Contributor

Backport failed for release-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.05
git worktree add -d .worktree/backport-347886-to-release-24.05 origin/release-24.05
cd .worktree/backport-347886-to-release-24.05
git switch --create backport-347886-to-release-24.05
git cherry-pick -x 19afd5603290706849c18ba5ad06684466c45ac9 a765e430e92e5d596ea561e807f8ebc256d8073f

Copy link
Contributor

@gepbird gepbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the update script, changes LGTM.

Related: #344204

@Artturin
Copy link
Member

#348120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update request: discord 0.70 → 0.71
4 participants