Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discord: format, update discord-canary and discord-ptb, refactor meta #347313

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

DontEatOreo
Copy link
Member

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@DontEatOreo DontEatOreo added 6.topic: darwin Running or building packages on Darwin backport release-24.05 Backport PR automatically labels Oct 8, 2024
@DontEatOreo
Copy link
Member Author

Result of nixpkgs-review pr 347313 run on aarch64-darwin 1

4 packages built:
  • discord
  • discord-canary
  • discord-development
  • discord-ptb

@DontEatOreo
Copy link
Member Author

Result of nixpkgs-review pr 347313 run on x86_64-darwin 1

4 packages built:
  • discord
  • discord-canary
  • discord-development
  • discord-ptb

@DontEatOreo
Copy link
Member Author

Result of nixpkgs-review pr 347313 run on x86_64-linux 1

@Scrumplex
Copy link
Member

Result of nixpkgs-review pr 347313 run on x86_64-linux 1

Copy link
Member

@Scrumplex Scrumplex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identical derivations as before on Linux

@gepbird
Copy link
Contributor

gepbird commented Oct 12, 2024

The update script was fixed in #347886, please rebase for the refactor changes

@DontEatOreo DontEatOreo changed the title discord: format, update darwin endpoints, update all darwin versions, refactor meta discord: format, update discord-canary and discord-ptb, refactor meta Oct 12, 2024
Copy link
Contributor

@gepbird gepbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

@DontEatOreo
Copy link
Member Author

Sorry for the extra force push; I realized I worded the update commits wrong fixed now

@DontEatOreo
Copy link
Member Author

Result of nixpkgs-review pr 347313 run on aarch64-darwin 1

2 packages built:
  • discord-canary
  • discord-ptb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants