Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discord: various updates #344204

Closed
wants to merge 7 commits into from
Closed

Conversation

jopejoe1
Copy link
Member

Description of changes

The update script failed for me, so I updated it to use the api endpoint instead.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Contributor

@gepbird gepbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 344204 run on x86_64-linux 1

3 packages built:
  • discord
  • discord-development
  • discord-ptb

Tested the stable package and the update script for it, LGTM!

@gepbird
Copy link
Contributor

gepbird commented Sep 24, 2024

Superseeds #344076

@gepbird
Copy link
Contributor

gepbird commented Sep 24, 2024

Why did discord-development get downgraded from 0.0.28 to 0.0.27?

@Artturin
Copy link
Member

Here's an updated discord-update.sh which makes the Discord updates commit and starts a rebase to squash the changes in to it.

#!/usr/bin/env bash

git commit --allow-empty -m 'Discord updates'
for d in discord discord-ptb discord-canary discord-development pkgsCross.aarch64-darwin.discord pkgsCross.aarch64-darwin.discord-ptb pkgsCross.aarch64-darwin.discord-canary pkgsCross.aarch64-darwin.discord-development; do
    nix-shell maintainers/scripts/update.nix --argstr commit true --argstr package "$d"
done
git rebase -i HEAD~"$(git log master..HEAD --oneline | wc -l)"

@gepbird
Copy link
Contributor

gepbird commented Oct 12, 2024

Superseded by #347886

@gepbird gepbird closed this Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants