Skip to content

Fixes ci, lint, and unit test issues for hardware connectivity. #13748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 24, 2022
Merged

Fixes ci, lint, and unit test issues for hardware connectivity. #13748

merged 3 commits into from
Feb 24, 2022

Conversation

tmashuang
Copy link
Contributor

@tmashuang tmashuang commented Feb 24, 2022 •
edited
Loading

Fixes ci, lint, and unit test issues for #12725. The base branch might need to be rebased with develop as there was a fixed for an e2e test that has been pulled into this branch.

@tmashuang tmashuang requested a review from a team as a code owner February 24, 2022 18:49
@tmashuang tmashuang requested review from digiwand and removed request for a team February 24, 2022 18:49
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tmashuang tmashuang requested a review from darkwing February 24, 2022 18:54
@metamaskbot
Copy link
Collaborator

Builds ready [1e1d17e]
Page Load Metrics (1201 ± 38 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint761227572532256
domContentLoaded1073141711997938
load1074141712017938
domInteractive1073141711997938

highlights:

storybook

@darkwing darkwing force-pushed the hardware-connectivity branch from 18aeeed to 743827d Compare February 24, 2022 20:30
@tmashuang tmashuang force-pushed the hardware-connectivity-test branch from 1e1d17e to cf86f8a Compare February 24, 2022 20:38
@metamaskbot
Copy link
Collaborator

Builds ready [cf86f8a]
Page Load Metrics (1120 ± 37 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint661277522467224
domContentLoaded1028128511187536
load1028129111207637
domInteractive1028128411187536

highlights:

storybook

@tmashuang tmashuang merged commit d8a6ed8 into hardware-connectivity Feb 24, 2022
@tmashuang tmashuang deleted the hardware-connectivity-test branch February 24, 2022 22:59
@github-actions github-actions bot locked and limited conversation to collaborators Feb 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@darkwing darkwing darkwing approved these changes

@digiwand digiwand Awaiting requested review from digiwand digiwand is a code owner automatically assigned from MetaMask/extension-devs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmashuang @metamaskbot @darkwing