Skip to content

Commit d8a6ed8

Browse files
authored
Fixes ci, lint, and unit test issues for hardware connectivity. (#13748)
* Remove unusual locales * Lint ignore line for todo function * Reduce length check for settings content row, but add LedgerTransportDropdown component check
1 parent 743827d commit d8a6ed8

File tree

3 files changed

+4
-10
lines changed

3 files changed

+4
-10
lines changed

app/_locales/en/messages.json

Lines changed: 0 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ui/components/app/confirm-page-container/confirm-page-container.component.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -177,6 +177,7 @@ export default class ConfirmPageContainer extends Component {
177177

178178
const { t } = this.context;
179179
/* ToDo: We need this method from elevated component */
180+
// eslint-disable-next-line no-unused-vars
180181
const onHardwareConnectivityClose = () => {
181182
console.log('Closing hardware connectivity');
182183
};

ui/pages/settings/advanced-tab/advanced-tab.component.test.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import sinon from 'sinon';
33
import { shallow } from 'enzyme';
44
import TextField from '../../../components/ui/text-field';
55
import ToggleButton from '../../../components/ui/toggle-button';
6+
import LedgerTransportDropdown from './ledger-transport-dropdown';
67
import AdvancedTab from './advanced-tab.component';
78

89
describe('AdvancedTab Component', () => {
@@ -35,7 +36,8 @@ describe('AdvancedTab Component', () => {
3536
});
3637

3738
it('should render correctly when threeBoxFeatureFlag', () => {
38-
expect(component.find('.settings-page__content-row')).toHaveLength(13);
39+
expect(component.find('.settings-page__content-row')).toHaveLength(12);
40+
expect(component.find(LedgerTransportDropdown)).toHaveLength(1);
3941
});
4042

4143
it('should update autoLockTimeLimit', () => {

0 commit comments

Comments
 (0)