Skip to content

Fixes ci, lint, and unit test issues for hardware connectivity. #13748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 24, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions app/_locales/en/messages.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,7 @@ export default class ConfirmPageContainer extends Component {

const { t } = this.context;
/* ToDo: We need this method from elevated component */
// eslint-disable-next-line no-unused-vars
const onHardwareConnectivityClose = () => {
console.log('Closing hardware connectivity');
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import sinon from 'sinon';
import { shallow } from 'enzyme';
import TextField from '../../../components/ui/text-field';
import ToggleButton from '../../../components/ui/toggle-button';
import LedgerTransportDropdown from './ledger-transport-dropdown';
import AdvancedTab from './advanced-tab.component';

describe('AdvancedTab Component', () => {
Expand Down Expand Up @@ -35,7 +36,8 @@ describe('AdvancedTab Component', () => {
});

it('should render correctly when threeBoxFeatureFlag', () => {
expect(component.find('.settings-page__content-row')).toHaveLength(13);
expect(component.find('.settings-page__content-row')).toHaveLength(12);
expect(component.find(LedgerTransportDropdown)).toHaveLength(1);
});

it('should update autoLockTimeLimit', () => {
Expand Down