Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a metadata property for nonRPCGasFeeApisDisabled #4245

Merged
merged 2 commits into from
May 7, 2024
Merged

Add a metadata property for nonRPCGasFeeApisDisabled #4245

merged 2 commits into from
May 7, 2024

Conversation

danjm
Copy link
Contributor

@danjm danjm commented May 2, 2024 •
edited
Loading

Explanation

This should have been part of #4094

The absence of this metadata results in an error being thrown from here: https://github.com/MetaMask/core/blob/main/packages/base-controller/src/BaseControllerV2.ts#L295-L297

Changelog

FIXED: Add metadata for the nonRPCGasFeeApisDisabled of gas-fee-controller state

@metamask/gas-fee-controller

  • FIXED: Add metadata for the nonRPCGasFeeApisDisabled of gas-fee-controller state

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@danjm danjm requested a review from a team as a code owner May 2, 2024 05:02
mcmire
mcmire approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@legobeat legobeat mentioned this pull request May 3, 2024
Closed
7 tasks
@danjm danjm merged commit 24cb7d1 into main May 7, 2024
143 checks passed
@danjm danjm deleted the add-gas-controller-metadata branch May 7, 2024 19:57
@danjm danjm mentioned this pull request May 7, 2024
Closed
7 tasks
@cryptotavares cryptotavares mentioned this pull request May 8, 2024
Closed
This was referenced May 10, 2024
Merged
Closed
Merged
Gudahtt added a commit that referenced this pull request May 10, 2024
@danjm @Gudahtt
Release/150.0.0 (#4275)
d30f7df 
Patch release of `GasFeeController` to fix an error being thrown in the
extension background.

This includes the PR #4245

---------

Co-authored-by: Mark Stacey <[email protected]>
@Gudahtt Gudahtt mentioned this pull request Aug 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmire mcmire mcmire approved these changes

@vthomas13 vthomas13 vthomas13 approved these changes

@matthewwalsh0 matthewwalsh0 matthewwalsh0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danjm @mcmire @vthomas13 @matthewwalsh0