Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 149.0.0 #4272

Merged
merged 7 commits into from
May 9, 2024
Merged

Release 149.0.0 #4272

merged 7 commits into from
May 9, 2024

Conversation

matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented May 8, 2024

Major release of TransactionController and UserOperationController to support gas fee updates in the extension.

Breaking changes added to changelog, no dependencies on unreleased packages.

Related:

@matthewwalsh0 matthewwalsh0 requested a review from a team as a code owner May 8, 2024 20:57
Gudahtt added a commit that referenced this pull request May 9, 2024
## Explanation

The version of the `@metamask/profile-sync-controller` package has been
updated to `0.0.0`, which is what our publishing automation expects of
all unpublished public packages.

The current version is `0.1.0`, which caused problems for our most
recent release, requiring a rollback. It broke publishing because our
publishing scripts tried to find version `0.1.0` in the package
changelog but were unable to.

This should have been caught by our linter, but it wasn't due to a
deficiency in the `@metamask/auto-changelog` validation command (it
doesn't validate that the current release exists). This problem has been
documented here: MetaMask/auto-changelog#192

## References

Unblocks #4272

## Changelog

N/A

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've highlighted breaking changes using the "BREAKING" category
above as appropriate
Gudahtt
Gudahtt previously approved these changes May 9, 2024
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One suggested improvement pending, not super important though

Co-authored-by: Mark Stacey <[email protected]>
@matthewwalsh0 matthewwalsh0 merged commit 652733f into main May 9, 2024
144 of 145 checks passed
@matthewwalsh0 matthewwalsh0 deleted the release/149.0.0 branch May 9, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants