Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Gas - Error: No metadata found for 'nonRPCGasFeeApisDisabled' #24383

Closed
seaona opened this issue May 6, 2024 · 2 comments · Fixed by #24520
Closed

[Bug]: Gas - Error: No metadata found for 'nonRPCGasFeeApisDisabled' #24383

seaona opened this issue May 6, 2024 · 2 comments · Fixed by #24520
Labels
release-11.16.0 Issue or pull request that will be included in release 11.16.0 release-12.0.0 Issue or pull request that will be included in release 12.0.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-transactions Transactions team type-bug

Comments

@seaona
Copy link
Contributor

seaona commented May 6, 2024

Describe the bug

When I start a tx I see the background error Error: No metadata found for 'nonRPCGasFeeApisDisabled'

Expected behavior

No response

Screenshots/Recordings

Screenshot from 2024-05-06 09-16-04

Steps to reproduce

  1. Start a tx
  2. Add recipient and amount
  3. Check console

Error messages or log output

No response

Version

develop (to check if it's present in RC / prod)

Build type

None

Browser

Chrome

Operating system

Linux

Hardware wallet

No response

Additional context

No response

Severity

No response

@seaona seaona added type-bug Sev2-normal Normal severity; minor loss of service or inconvenience. labels May 6, 2024
@gauthierpetetin gauthierpetetin added the team-confirmations Push issues to confirmations team label May 6, 2024
@cryptotavares
Copy link
Contributor

This has been fixed here, but still needs to be adopted in the clients.

@cryptotavares cryptotavares added team-transactions Transactions team and removed team-confirmations Push issues to confirmations team labels May 8, 2024
danjm added a commit that referenced this issue May 15, 2024
## **Description**

Updates the gas fee controller to v11.15.2, so that the gas fee
controller is instantiated with the proper metadata.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/24520?quickstart=1)

## **Related issues**

Fixes: #24383

## **Manual testing steps**

1. Start a tx
2. Add recipient and amount
3. Check console, there should not be a `Error: No metadata found for
'nonRPCGasFeeApisDisabled'`

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
danjm added a commit that referenced this issue May 16, 2024
Updates the gas fee controller to v11.15.2, so that the gas fee
controller is instantiated with the proper metadata.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/24520?quickstart=1)

Fixes: #24383

1. Start a tx
2. Add recipient and amount
3. Check console, there should not be a `Error: No metadata found for
'nonRPCGasFeeApisDisabled'`

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@metamaskbot metamaskbot added the release-11.16.0 Issue or pull request that will be included in release 11.16.0 label May 17, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-11.16.0 on issue. Adding release label release-11.16.0 on issue, as issue is linked to PR #24520 which has this release label.

@gauthierpetetin gauthierpetetin added the release-12.0.0 Issue or pull request that will be included in release 12.0.0 label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-11.16.0 Issue or pull request that will be included in release 11.16.0 release-12.0.0 Issue or pull request that will be included in release 12.0.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-transactions Transactions team type-bug
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants