Update/nft methods #317
Open
Update/nft methods #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Indicated proxy_auth is optional and defaults to false.
Readded BSC chain
fixed nft_req
Created enable_nft file (based on enable_erc20)
Added NftProvider object to common structures
Changed activation_param definition to be a standard NftProvider object
NFT RPC Methods Docs update
smk762
requested review from
gcharang,
AndrewDelaney,
laruh and
ShantanuSharma9873
laruh
requested changes
Aug 25, 2024
src/pages/komodo-defi-framework/api/v20/enable_eth_with_tokens/index.mdx
Outdated
Show resolved
Hide resolved
src/pages/komodo-defi-framework/api/v20-dev/non_fungible_tokens/update_nft/index.mdx
Outdated
Show resolved
Hide resolved
src/pages/komodo-defi-framework/api/v20-dev/non_fungible_tokens/update_nft/index.mdx
Outdated
Show resolved
Hide resolved
src/pages/komodo-defi-framework/api/v20-dev/non_fungible_tokens/enable_nft/index.mdx
Outdated
Show resolved
Hide resolved
src/pages/komodo-defi-framework/api/v20-dev/non_fungible_tokens/enable_nft/index.mdx
Outdated
Show resolved
Hide resolved
src/pages/komodo-defi-framework/api/common_structures/nfts/index.mdx
Outdated
Show resolved
Hide resolved
|
Preview for merge commit: 7019a83, available on cloudflare at: https://5b965a8c.komodo-docs.pages.dev/en/docs/ |
|
Preview for merge commit: 7019a83, available on cloudflare at: https://8960ebf3.komodo-docs.pages.dev/en/docs/ |
|
Preview for merge commit: 3c6541f, available on cloudflare at: https://c3b10cf0.komodo-docs.pages.dev/en/docs/ |
…nks, formatted md content, checked presence of file and dirs based on sidebar, checked presence of h1 in every file, update Komodo DeFi Framework methods table, adds/updates preview images when base is main
laruh
requested changes
Sep 17, 2024
| | maker\_swap\_v2\_contract | string | Address for the maker's new V2 swap smart contract. Must be provided if "use\_trading\_proto\_v2"is true in mm2 configuration | | ||
| | taker\_swap\_v2\_contract | string | Address for the taker's new V2 swap smart contract. Must be provided if "use\_trading\_proto\_v2"is true in mm2 configuration | | ||
| | nft\_maker\_swap\_v2\_contract | string | Address for the maker's new V2 NFT swap smart contract. Must be provided if "use\_trading\_proto\_v2"is true in mm2 configuration | | ||
| | nft\_taker\_swap\_v2\_contract | string | Address for the taker's new V2 NFT swap smart contract. Must be provided if "use\_trading\_proto\_v2"is true in mm2 configuration | |
There was a problem hiding this comment.
we dont have nft taker smart contact field in Komodo DeFi project and such solidity contract in Etomic Swap project.
Right now we are focusing on Nft maker swap operations, where Maker is Nft owner.
| "maker_swap_v2_contract": "0x9130b257D37A52E52F21054c4DA3450c72f595CE", | ||
| "taker_swap_v2_contract": "0x9130b257D37A52E52F21054c4DA3450c72f595CE", | ||
| "nft_maker_swap_v2_contract": "0x9130b257D37A52E52F21054c4DA3450c72f595CE", | ||
| "nft_taker_swap_v2_contract": "0x9130b257D37A52E52F21054c4DA3450c72f595CE", |
There was a problem hiding this comment.
nft_taker_swap_v2_contract also should be removed according to the comment above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues from #270