Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tendermint activation to postman collection #318

Open
wants to merge 18 commits into
base: dev
Choose a base branch
from

Conversation

smk762
Copy link
Contributor

@smk762 smk762 commented Sep 6, 2024

Closes #311
Added examples and note in doc for breaking change at next release

Copy link

github-actions bot commented Sep 6, 2024

Preview for merge commit: 26fb706, available on cloudflare at: https://67aff3cf.komodo-docs.pages.dev/en/docs/

@@ -29,6 +29,10 @@ Use this method to activate Tendermint coins (COSMOS/IRIS/OSMOSIS) and IBC asset
| tokens\_balances | array of objects | Only returned when `get_balances` is `true`. A list of standard [AddressInfo](/komodo-defi-framework/api/common_structures/#address-info) objects, one for each token. |
| tokens\_tickers | array | Only returned when `get_balances` is `false`. A list of each token which was activated. |

<Note>
The `rpc_urls` parameter will be replaced with the `nodes` parameter in the next release. Instead of a list of url strings, the `nodes` parameter will be a list of [EvmNode objects](/komodo-defi-framework/api/common_structures/activation/#evm-node).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the "EvmNode objects" part intentional here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've duplicated the EvmNode object and named it TendermintNode in common structures for better clarity.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gui_auth is no longer used. We renamed it as komodo_proxy

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated this across the docs & postman, with a note Prior to the v2.2.0 release, the "gui_auth" field was used to access RPC nodes run officially by the Komodo Platform team. This field was replaced with the "komodo_auth" field in the v2.2.0 release.

Copy link

Preview for merge commit: f98b510, available on cloudflare at: https://b3809aa0.komodo-docs.pages.dev/en/docs/

@github-actions github-actions bot requested a deployment to komodo-docs (Preview) September 11, 2024 11:44 Abandoned
Copy link

Preview for merge commit: 8cff8d3, available on cloudflare at: https://650bbf3c.komodo-docs.pages.dev/en/docs/

Copy link

Preview for merge commit: ffa9df1, available on cloudflare at: https://182d9378.komodo-docs.pages.dev/en/docs/

Copy link

Preview for merge commit: 1328524, available on cloudflare at: https://622155d8.komodo-docs.pages.dev/en/docs/

smk762 and others added 4 commits September 13, 2024 09:29
…nks, formatted md content, checked presence of file and dirs based on sidebar, checked presence of h1 in every file, update Komodo DeFi Framework methods table, adds/updates preview images when base is main
Copy link

Preview for merge commit: 961c339, available on cloudflare at: https://9f09a084.komodo-docs.pages.dev/en/docs/

Copy link

Preview for merge commit: ba635f5, available on cloudflare at: https://be08bf56.komodo-docs.pages.dev/en/docs/

smk762 and others added 3 commits October 30, 2024 16:34
…nks, formatted md content, checked presence of file and dirs based on sidebar, checked presence of h1 in every file, update Komodo DeFi Framework methods table, adds/updates preview images when base is main
Copy link

github-actions bot commented Nov 1, 2024

Preview for merge commit: 3cd313c, available on cloudflare at: https://d6c87192.komodo-docs.pages.dev/en/docs/

Copy link

github-actions bot commented Nov 1, 2024

Preview for merge commit: b532c9e, available on cloudflare at: https://3b3d87f5.komodo-docs.pages.dev/en/docs/

Copy link

github-actions bot commented Nov 1, 2024

Preview for merge commit: 5590c55, available on cloudflare at: https://bd2125b6.komodo-docs.pages.dev/en/docs/

Copy link
Member

@onur-ozkan onur-ozkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than one note

Copy link

github-actions bot commented Nov 9, 2024

Preview for merge commit: 19ae023, available on cloudflare at: https://52e7fd08.komodo-docs.pages.dev/en/docs/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting merge KDF 2.2.0-beta P1 Important task which needs to be completed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants