-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tendermint activation to postman collection #318
base: dev
Are you sure you want to change the base?
Conversation
Preview for merge commit: 26fb706, available on cloudflare at: https://67aff3cf.komodo-docs.pages.dev/en/docs/ |
@@ -29,6 +29,10 @@ Use this method to activate Tendermint coins (COSMOS/IRIS/OSMOSIS) and IBC asset | |||
| tokens\_balances | array of objects | Only returned when `get_balances` is `true`. A list of standard [AddressInfo](/komodo-defi-framework/api/common_structures/#address-info) objects, one for each token. | | |||
| tokens\_tickers | array | Only returned when `get_balances` is `false`. A list of each token which was activated. | | |||
|
|||
<Note> | |||
The `rpc_urls` parameter will be replaced with the `nodes` parameter in the next release. Instead of a list of url strings, the `nodes` parameter will be a list of [EvmNode objects](/komodo-defi-framework/api/common_structures/activation/#evm-node). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was the "EvmNode objects" part intentional here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, the EvmNode
object is like https://182d9378.komodo-docs.pages.dev/en/docs/komodo-defi-framework/api/common_structures/activation/#evm-node
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've duplicated the EvmNode
object and named it TendermintNode
in common structures for better clarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gui_auth
is no longer used. We renamed it as komodo_proxy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated this across the docs & postman, with a note Prior to the v2.2.0 release, the "gui_auth" field was used to access RPC nodes run officially by the Komodo Platform team. This field was replaced with the "komodo_auth" field in the v2.2.0 release.
Preview for merge commit: f98b510, available on cloudflare at: https://b3809aa0.komodo-docs.pages.dev/en/docs/ |
Preview for merge commit: 8cff8d3, available on cloudflare at: https://650bbf3c.komodo-docs.pages.dev/en/docs/ |
Preview for merge commit: ffa9df1, available on cloudflare at: https://182d9378.komodo-docs.pages.dev/en/docs/ |
Preview for merge commit: 1328524, available on cloudflare at: https://622155d8.komodo-docs.pages.dev/en/docs/ |
…nks, formatted md content, checked presence of file and dirs based on sidebar, checked presence of h1 in every file, update Komodo DeFi Framework methods table, adds/updates preview images when base is main
Preview for merge commit: 961c339, available on cloudflare at: https://9f09a084.komodo-docs.pages.dev/en/docs/ |
Preview for merge commit: ba635f5, available on cloudflare at: https://be08bf56.komodo-docs.pages.dev/en/docs/ |
…nks, formatted md content, checked presence of file and dirs based on sidebar, checked presence of h1 in every file, update Komodo DeFi Framework methods table, adds/updates preview images when base is main
Preview for merge commit: 3cd313c, available on cloudflare at: https://d6c87192.komodo-docs.pages.dev/en/docs/ |
Preview for merge commit: b532c9e, available on cloudflare at: https://3b3d87f5.komodo-docs.pages.dev/en/docs/ |
Preview for merge commit: 5590c55, available on cloudflare at: https://bd2125b6.komodo-docs.pages.dev/en/docs/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than one note
src/pages/komodo-defi-framework/api/common_structures/activation/index.mdx
Outdated
Show resolved
Hide resolved
Preview for merge commit: 19ae023, available on cloudflare at: https://52e7fd08.komodo-docs.pages.dev/en/docs/ |
Closes #311
Added examples and note in doc for breaking change at next release