Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Eth coin with tokens v2 activation update #310

Open
laruh opened this issue Aug 2, 2024 · 2 comments
Open

Document Eth coin with tokens v2 activation update #310

laruh opened this issue Aug 2, 2024 · 2 comments
Assignees
Labels
awaiting review KDF 2.2.0-beta P1 Important task which needs to be completed soon

Comments

@laruh
Copy link
Member

laruh commented Aug 2, 2024

related to KDF PR KomodoPlatform/komodo-defi-framework#2129

In the PR optional swap_v2_contracts field was added in EthActivationV2Request request ("enable_eth_with_tokens" RPC).

it is a structure with such fields

    "swap_v2_contracts":{
	    "maker_swap_v2_contract": "0x9130b257D37A52E52F21054c4DA3450c72f595CE",
	    "taker_swap_v2_contract": "0x9130b257D37A52E52F21054c4DA3450c72f595CE",
	    "nft_maker_swap_v2_contract": "0x9130b257D37A52E52F21054c4DA3450c72f595CE"
    }, 

This field MUST be provided if this flag "use_trading_proto_v2":true was provided in kdf json configuration when you start the program.

Req example

curl --url "http://127.0.0.1:7783" --data '{
  "userpass": "'$USERPASS'",
  "method": "enable_eth_with_tokens",
  "mmrpc": "2.0",
  "params": {
    "ticker": "MATIC",
    "mm2": 1,
    "swap_contract_address": "0x9130b257D37A52E52F21054c4DA3450c72f595CE",
    "swap_v2_contracts":{
	    "maker_swap_v2_contract": "0x9130b257D37A52E52F21054c4DA3450c72f595CE",
	    "taker_swap_v2_contract": "0x9130b257D37A52E52F21054c4DA3450c72f595CE",
	    "nft_maker_swap_v2_contract": "0x9130b257D37A52E52F21054c4DA3450c72f595CE"
    },    
    "fallback_swap_contract": "0x9130b257D37A52E52F21054c4DA3450c72f595CE",
    "nodes": [
      {
        "url": "https://polygon-rpc.com"
      }
    ],
    "erc20_tokens_requests": [],
    "nft_req": {
      "provider":{
        "type": "Moralis",
        "info": {
          "url":"http://localhost:6150/nft-test",
          "proxy_auth":true
        }
      }
    }
  }
}'

Note: optional "proxy_auth" bool field in "nft_req" was added in this req KomodoPlatform/komodo-defi-framework#2100 it means if "proxy_auth":true then Komodo-Proxy url should be provided (https://github.com/KomodoPlatform/komodo-defi-proxy).

@laruh
Copy link
Member Author

laruh commented Aug 2, 2024

upd I suppose this pr is going to fix the issue #270

@smk762
Copy link
Contributor

smk762 commented Sep 10, 2024

Will be resolved with #317

@smk762 smk762 added the P1 Important task which needs to be completed soon label Sep 13, 2024
@smk762 smk762 self-assigned this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review KDF 2.2.0-beta P1 Important task which needs to be completed soon
Projects
None yet
Development

No branches or pull requests

2 participants