-
Notifications
You must be signed in to change notification settings - Fork 14
Conversation
@danlamanna can you pastry in a screenshot? |
tasty, thanks. |
C'mon, you couldn't get a donut logo up there @danlamanna? disappointed |
@danlamanna See my changes here: 6ede95f to fix the map size issues. I had to go up the div hierarchy to set all the element heights to 100%. The only other way to so solve this is to explicitly initialize the map with a given size (and manage any and all size changes that may occur). Note: I also changed how the stylus files are built so that I can get the header height variable inside a different file. There are other ways to handle this, but importing (or requiring) files from a single place resembles what we should be doing with webpack. |
@jbeezley Thanks for figuring that out, that was more involved than I would have expected.
🎤 💧 |
Yeah, I've come to see it like this. Normally, unless otherwise stated, a parent element is only as large as the content it contains.. Trying to have an element expand to take up 100% of it's parent inverts the usual pattern, so you have to go all the way up the document tree to make it work. There are all kind of other implications in positioning you run into as well because it disrupts the whole document flow. |
* Upon confirmation, physically removes the DOM element while | ||
* storing the change in the session attributes. This also | ||
* enables the save button. | ||
**/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I take it there is no way to add the panel back after removing it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, unless you were to manually edit the session.json. It seems like having a dropdown with available panels is something @aashish24 wants at some point - so that could add that functionality.
this.layout = { | ||
panelGroups: [ | ||
{ | ||
id: 'm-core-panel-group', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
m-main-panel-group
}, | ||
|
||
collapsePanel: function (e) { | ||
$(e.currentTarget).find('i.icon-up-open').attr('class', 'icon-down-open'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably beating a 💀 🐴 here, similar to this comment, what would be nice is if the three methods
removePanel
expandPanel
collapsePanel
would trigger a change on the layout of the session model, and then the session view can be listening for changes on the session model which would re-render the panels and also enable the save button at the appropriate times.
All changes for #225.
@mgrauer See my comments on #235, aside from that I think we should consider having the panel views call initialize on their parent PanelView and we can take care of the extending of events there, that way if we want to do something else in the future things will "just work". |
Forget what I said on that first PR I created. I've created a new one #236 to merge into here. If those are OK with you, you can merge it. I like your idea of the panel views calling initialize on their parent PanelView. Can you do that after you've merged #236, and also update the docs? Then I think this would be ready to go. |
Alright @mgrauer - one last look. |
LGTM. Awesome work @danlamanna . Thanks for pushing this refactor through, I think it is a big improvement in the UI and in extensibility. We should be on the lookout for small bugs to clean up in the near future. |
Configurable Layout/UI Refactor
🎊 |
This PR addresses #182, #184, #185, and #186.
The biggest addition is defining a layout for Minerva that can be configured by 3rd party plugins, shown here.
Other changes include:
Concerns that need to be addressed before merge:
I'm largely unfamiliar with how this is being used in BSVE, and for Epidemico's work@mgrauer will make sure this works in the BSVE context before giving final approvalReview from someone with their own projects would be greatly appreciated
I removed the baselayer settings button, since I removed the title bar off the map. What is the stopgap to get this merged?noted in Refactor session model/save #225I removed the add dataset button, this should be added back in the form of the + icon similar to sourcesI'm somewhat uneasy about how panels are added to panel groups but wasn't entirely sure what the proper Backbone way wasUpdate: apparently this isn't as hacky as I thought
Future concerns: