This repository has been archived by the owner on Jan 9, 2020. It is now read-only.
Ui refactor eyeball #235
Closed
Ui refactor eyeball #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I fixed the feature info widget issue. From my perspective this is ready to go in. @danlamanna let me know what you think
|
|
@mgrauer These changes look good to me, how do you want to handle the separate PRs (since it looks like you want to merge this into master)? Next time I would probably start the PR trying to merge into my pre-existing one, IIRC github does not let you change the target branch after the fact. |
5 tasks
|
I can push these commits on top of your branch with that active PR, then close this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@danlamanna This is largely #226. I wanted to add some changes, but didn't want to stomp on any work of yours. Please check this PR out before doing any further work on #226.
I realized that we lost some of the layer ordering functionality, and the display of eye icons for the layers, so I added those back in.
I also addressed the remaining comments I had in #226. Let me know what you think, especially about the changes to the panel-title mixin.
One last issue I've found is that this PR obscures the ability to bring up the WMS feature info. I'll look into that later on tonight or tomorrow.