-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce supplementary datums #640
Conversation
cc @mmontin: is this something you would benefit from? |
-- Supplemental datums can be added to the transaction if the corresponding | ||
-- datum hash exists at a input in that transaction. | ||
data TxSupplementalData era where |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we're using both plural forms of datum: data and datums. Maybe we should stick to one or the other?
This also applies to the name of the function convSupplementalDatums
which consumes TxSupplementalData
.
(ledger even has TxDats
!?)
convSupplementalDatums sbe (TxSupplementalData datums) = | ||
shelleyBasedEraConstraints sbe $ | ||
L.TxDats $ | ||
Map.fromList |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Map.fromList | |
fromList |
Update convScriptData to include supplemental datums
578f7fb
to
9e412ac
Compare
9e412ac
to
ecc1623
Compare
Changelog
Context
Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist