Introduce supplementary datums #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
requested review from
dcoutts,
erikd,
newhoggy,
carbolymer,
smelc,
palas,
kevinhammond,
CarlosLopezDeLara and
disassembler
as code owners
|
cc @mmontin: is this something you would benefit from? |
carbolymer
approved these changes
Sep 17, 2024
Comment on lines
1159
to
1161
| -- Supplemental datums can be added to the transaction if the corresponding | ||
| -- datum hash exists at a input in that transaction. | ||
| data TxSupplementalData era where |
There was a problem hiding this comment.
Here we're using both plural forms of datum: data and datums. Maybe we should stick to one or the other?
This also applies to the name of the function convSupplementalDatums which consumes TxSupplementalData.
(ledger even has TxDats!?)
| convSupplementalDatums sbe (TxSupplementalData datums) = | ||
| shelleyBasedEraConstraints sbe $ | ||
| L.TxDats $ | ||
| Map.fromList |
There was a problem hiding this comment.
Suggested change
| Map.fromList | |
| fromList |
Update convScriptData to include supplemental datums
Jimbo4350
force-pushed
the
jordan/introduce-supplementary-datums
branch
2 times, most recently
from
578f7fb
to
9e412ac
Compare
Jimbo4350
force-pushed
the
jordan/introduce-supplementary-datums
branch
from
9e412ac
to
ecc1623
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist