Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for supplementary datums #902

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add support for supplementary datums #902

wants to merge 4 commits into from

Conversation

Jimbo4350
Copy link
Contributor

@Jimbo4350 Jimbo4350 commented Sep 18, 2024 •
edited by carbolymer
Loading

Changelog

- description: |
    Add support for supplementary datums

  type:
  - feature        # introduces a new feature

Context

Integrates:

Implements:

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@Jimbo4350 Jimbo4350 force-pushed the jordan/add-support-for-supplemental-datums branch 2 times, most recently from e69c23c to 56da39e Compare September 18, 2024 20:16
@Jimbo4350 Jimbo4350 force-pushed the jordan/add-support-for-supplemental-datums branch from 56da39e to 7bbf992 Compare October 21, 2024 16:11
@Jimbo4350 Jimbo4350 marked this pull request as ready for review October 21, 2024 16:12
@Jimbo4350 Jimbo4350 force-pushed the jordan/add-support-for-supplemental-datums branch 2 times, most recently from a535fc5 to d0ac7e3 Compare October 21, 2024 19:52
@Jimbo4350
Copy link
Contributor Author

This will work but I need to modify the PR a little more to improve the user experience.

@Jimbo4350 Jimbo4350 force-pushed the jordan/add-support-for-supplemental-datums branch 3 times, most recently from 8444f82 to 0b06467 Compare October 24, 2024 20:06
@Jimbo4350 Jimbo4350 force-pushed the jordan/add-support-for-supplemental-datums branch from 0b06467 to 55fdf6c Compare October 24, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carbolymer carbolymer carbolymer approved these changes

@newhoggy newhoggy Awaiting requested review from newhoggy newhoggy is a code owner

@smelc smelc Awaiting requested review from smelc smelc is a code owner

@palas palas Awaiting requested review from palas palas is a code owner

@kevinhammond kevinhammond Awaiting requested review from kevinhammond kevinhammond is a code owner

@disassembler disassembler Awaiting requested review from disassembler disassembler is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jimbo4350 @carbolymer