Extra HashableScriptData in TxBody for PK inputs and reference inputs with hashed datums.
#637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smelc
reviewed
Sep 13, 2024
Comment on lines
+727
to
+730
| data PrivateKeyWitness witctx era where | ||
| PrivateKeyWitness | ||
| :: KeyDatum witctx | ||
| -> PrivateKeyWitness witctx era |
There was a problem hiding this comment.
Can you make this not a GADT? I know there are lots of them floating around but we are actually moving away from using GADTs when not needed.
There was a problem hiding this comment.
Yes i can. I basically just mimicked how other types around were defined. But indeed GADTs are not necessary there.
smelc
reviewed
Sep 13, 2024
Comment on lines
+787
to
+789
| data KeyDatum witctx where | ||
| KeyDatumForTxIn :: Maybe HashableScriptData -> KeyDatum WitCtxTxIn | ||
| NoKeyDatumForStake :: KeyDatum WitCtxStake |
There was a problem hiding this comment.
Can you make this not a GADT? I know there are lots of them floating around but we are actually moving away from using GADTs when not needed.
Jimbo4350
requested changes
Sep 13, 2024
|
@Jimbo4350 I barely started and I was in need for feedback in case there was a better way to approach this, but that's fine by me if you handle it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to solve issue #600 by allowing users to provide instances of
HashableScriptDatafor hashed datums located:For now, these data can only be provided:
This contribution intends to be as little invasive as possible, and to respect the current way of handling the creation of the data map provided in the script context. The map is currently built by browsing through the relevant parts of the body content and retrieving the relevant data there. Thus, the idea here is not to create a new field in the body content, but instead to allow user to add additional
HashableScriptDataat two addition locations in the body content.