chore: increase version number to 0.16.24 #2170
Conversation
github-actions
bot
added
the
maintenance
github-actions
bot
added
maintenance
| @@ -129,7 +129,7 @@ jobs: | |||
| echo "Version Code: $VERSION_CODE" | |||
| echo "Version: $VERSION" | |||
| # This will need to change currently looking for specific version and not place holder | |||
| sed -i -e "s/16022/$VERSION_CODE/g" -e "s/0.16.22/$VERSION/g" ./android/app/build.gradle | |||
There was a problem hiding this comment.
@jfmcquade Should this be added to the script yarn scripts version? This is what I normally use to bump the version but it only updates the other two places...
There was a problem hiding this comment.
Good point. Really we want to action #2136, but this is probably a good idea in the short term, I'll have a look
There was a problem hiding this comment.
If we're updating the android build number for content repos shouldn't we be using a variable coming from the content repo itself? E.g. the content repo version number...
There was a problem hiding this comment.
I've also bumped the version number in the github workflow reusable-android-build.yml, which is used by content repos. Currently it's still looking for a specific version number (now increased to match the other files) to replace with the target version number specified by the repo that is invoking the action. This is a workaround awaiting fixing #2136
github-actions
bot
added
maintenance
PR Checklist
Description
PR increase version number to 0.16.24