hotfix: yarn scripts version also updates strings targeted by android build action #2171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Think I'm somewhat out on the loop on this, didn't even realise we had this set of reusable actions/workflows for content repos (can see added over course of various prs without review and also a few commits direct to master which I'd strongly discourage against as a practice)
Given now we're updating scripts to fix what is already a temporary workaround I'd probably suggest better to just make a more-permanent fix to allow authors control over the capacitor config and android build process
esmeetewinkel
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Functional test passed. Merging this as this makes my life strictly easier while awaiting improvements suggested in #2136
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Description
As suggested in this comment, adds an ugly workaround whereby running
yarn scripts versionupdates the version values targeted for replacement by.github/workflows/reusable-android-build.ymlto match the new values populated to./android/app/build.gradle.As mentioned, this is a temporary workaround pending directly addressing #2136.
Testing
With this PR branch checked out, run
yarn scripts versionwith a sensible value, and ensure that the changes to all 3 files look correctGit Issues
Closes #