hotfix: revert version number in build.gradle and reausable-android-build action #2190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esmeetewinkel
approved these changes
Jan 31, 2024
esmeetewinkel
deleted the
hotfix/reusable-android-build-action-target-version
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Description
The android_release action on the plh-facilitator-mx repo is failing. This is likely due to the merging of #2170 – the plh-facilitator-mx repo targets release v0.16.23 of the code, but uses the
reusable-android-releaseaction from master. As this action looks for a specific release number string to be replaced, and as #2170 had updated the target number, the number was not being replaced correctly.This is a temporary workaround: the action should be reworked to target a placeholder variable instead of a specific version number, or a more thorough improvement should be implemented, as suggested in #2136
Git Issues
Closes #