You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What?
When creating android releases on deployment branch main app repo is checked out during action, and therefore has the default capacitor.config.ts. It would be useful to allow authors to specify things like app_id and other config overrides in the deployment config.ts, and include overwrite as part of android build workflows
Additionally the android versioning script works from the main package.json, but would probably make more sense to assign based on content version (or combined content/builder)
Ideally these updates can then be incorporated into a new template in packages/actions/templates
It would be worth discussing any other requirements for content repos or how best to prioritise/achieve these items
Just to comment that ideally whatever improvements made should ideally replace the custom string edits made to handle version codes in .github/workflows/reusable-android-build.yml, and deprecate the changes introduced #2171
What?
When creating android releases on deployment branch main app repo is checked out during action, and therefore has the default
capacitor.config.ts
. It would be useful to allow authors to specify things like app_id and other config overrides in the deployment config.ts, and include overwrite as part of android build workflowsAdditionally the android versioning script works from the main package.json, but would probably make more sense to assign based on content version (or combined content/builder)
Ideally these updates can then be incorporated into a new template in
packages/actions/templates
It would be worth discussing any other requirements for content repos or how best to prioritise/achieve these items
Other details
Workarounds for issue above in deployment repo:
https://github.com/IDEMSInternational/plh-facilitator-app-my-content/blob/main/.github/workflows/android_build.yml
The text was updated successfully, but these errors were encountered: