Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Deployment repo android build improvements #2136

Closed
chrismclarke opened this issue Nov 7, 2023 · 1 comment · Fixed by #2252
Closed

[FEATURE] Deployment repo android build improvements #2136

chrismclarke opened this issue Nov 7, 2023 · 1 comment · Fixed by #2252
Assignees
Labels
feature Work on app features/modules needs discussion Needs discussion

Comments

@chrismclarke
Copy link
Member

chrismclarke commented Nov 7, 2023

What?
When creating android releases on deployment branch main app repo is checked out during action, and therefore has the default capacitor.config.ts. It would be useful to allow authors to specify things like app_id and other config overrides in the deployment config.ts, and include overwrite as part of android build workflows

Additionally the android versioning script works from the main package.json, but would probably make more sense to assign based on content version (or combined content/builder)

Ideally these updates can then be incorporated into a new template in packages/actions/templates

It would be worth discussing any other requirements for content repos or how best to prioritise/achieve these items

Other details
Workarounds for issue above in deployment repo:
https://github.com/IDEMSInternational/plh-facilitator-app-my-content/blob/main/.github/workflows/android_build.yml

@chrismclarke
Copy link
Member Author

Just to comment that ideally whatever improvements made should ideally replace the custom string edits made to handle version codes in .github/workflows/reusable-android-build.yml, and deprecate the changes introduced #2171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Work on app features/modules needs discussion Needs discussion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants